Update integrations tests #3817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SpacePossum
commented
Jun 6, 2018
| @@ -153,7 +153,6 @@ public function provideFixersPriorityCases() | |||
| array($fixers['phpdoc_summary'], $fixers['phpdoc_trim']), | |||
| array($fixers['phpdoc_to_comment'], $fixers['no_empty_comment']), | |||
| array($fixers['phpdoc_to_comment'], $fixers['phpdoc_no_useless_inheritdoc']), | |||
| array($fixers['phpdoc_var_without_name'], $fixers['phpdoc_trim']), | |||
There was a problem hiding this comment.
there is no priority issue between these fixers
|
Please rebase onto 2.12. |
|
we're not doing a 2.2.21? |
|
Nope: https://medium.com/@keradus/to-make-a-difference-8dce5f7cf9bf Though branch 2.12 doesn't exist yet, I guess master is fine for now. |
julienfalque
approved these changes
Jun 10, 2018
|
resolved conflicts after target branch was changed, forced pushed |
SpacePossum
added a commit
that referenced
this pull request
Jul 2, 2018
This PR was merged into the 2.12 branch. Discussion ---------- Update integrations tests Commits ------- 73adc32 Update integrations tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.