PhpUnitDedicateAssertFixer - fix "sizeOf" same as "count" #3813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| public function testAssertCountFromSame($expected, $input = null) | ||
| { | ||
| if (null === $input) { | ||
| $expected = str_replace('count', 'sizeOf', $expected); |
There was a problem hiding this comment.
This will never run any test case with entirely lowercased sizeof, which is probably the most common usage. I'd rather rewrite the data provider so that different casings are tested just like with count.
There was a problem hiding this comment.
👍 fixed by using some templating
julienfalque
approved these changes
Jun 14, 2018
SpacePossum
added a commit
that referenced
this pull request
Jul 4, 2018
…. (SpacePossum) This PR was merged into the 2.13-dev branch. Discussion ---------- PhpUnitDedicateAssertFixer - fix "sizeOf" same as "count". @ see #3785 (comment) Commits ------- 67d4f8c PhpUnitDedicateAssertFixer - fix "sizeOf" same as "count".
keradus
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ see #3785 (comment)