Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DX: enable native_function_invocation #3798

Merged
merged 1 commit into from Aug 19, 2018
Merged

DX: enable native_function_invocation #3798

merged 1 commit into from Aug 19, 2018

Conversation

keradus
Copy link
Member

@keradus keradus commented May 31, 2018

please vote

@keradus
Copy link
Member Author

keradus commented May 31, 2018

ping @FriendsOfPHP/php-cs-fixer

@ntzm
Copy link
Contributor

ntzm commented May 31, 2018

What are the before and after benchmarks?

@kubawerlos
Copy link
Contributor

Why not all native functions?

@keradus
Copy link
Member Author

keradus commented May 31, 2018

@ntzm , minimal compared to fun with tokenizer
@kubawerlos , see discussion at #3048

@SpacePossum SpacePossum mentioned this pull request Jul 5, 2018
Merged
@keradus keradus changed the base branch from master to 2.12 July 6, 2018 09:17
@keradus keradus added this to the 2.12.3 milestone Jul 6, 2018
@keradus keradus merged commit 2f48a42 into PHP-CS-Fixer:2.12 Aug 19, 2018
keradus added a commit that referenced this pull request Aug 19, 2018
@keradus
minor #3798 DX: enable native_function_invocation (keradus)
f070c3a 
This PR was squashed before being merged into the 2.12 branch (closes #3798).

Discussion
----------

DX: enable native_function_invocation

please vote

Commits
-------

2f48a42 DX: enable native_function_invocation
@keradus keradus deleted the master_rule1 branch August 19, 2018 22:13
@Kdecherf Kdecherf mentioned this pull request Sep 5, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.12.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@keradus @ntzm @kubawerlos