New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 BUG: Circular dependency fix broke starting up with some packages #3682
Comments
Confirm I upgraded Snowpack to latest version and I am running in with the same issue |
one more. seeing it in 3.8.8 and as far back as 3.8.5? |
Can confirm this is still happening on 3.8.8
|
Seeing this also on 3.8.8, trying to use
The Repro:
|
I want to also point out that I added the offending packages in the knownEntrypoints array like the warning suggests and the message still shows up. |
Any workaround folks, like should we downgrade snowpack to an older version? |
I just ignore it, the warning is only in dev mode but when actually building there's no warning. |
It crashes out, it’s not just a warning… |
Right, I was only affected by the warnings which is only half of the issue. |
I had to downgrade because this broke my existing project as is, and the only reason I have to upgrade--Nivo--still will not work even in this minimal example project. I know I saw somewhere there was a test specifically to run a project with Nivo but I've been unable to get any barebones project running with that package so I'm not quite sure how it is supposed to function or if there's some configuration I'm missing. I am entirely blocked from upgrading because of this bug, even without Nivo. |
Rolling snowpack back to |
It seems to break in the first I did a quick scan on the changes between 3.8.6 and 3.8.7. I have a hunch that the issue is caused by something in snowpack/src/sources/local.ts, probably something with the memoization stuff. There are also some changes in the Can anyone confirm that |
@gerarts I can confirm that |
Thanks @gerarts, |
#3859 looks like a simple, straight forward fix for this without any complications. @FredKSchott what's currently keeping you from merging it? Can I help with that PR in some way? |
I downgraded it to 3.8.6 and I can't believe it worked... I was stucked at this problem. |
Quick checklist
What package manager are you using?
npm
What operating system are you using?
macOS
Describe the bug
The PR #3562 seems to have caused some issues with both the package Nivo it was trying to fix, as well as others.
A lot of errors similar to this pop up:
As well as a lot of these:
though I only included lodash in this list, the same sort of errors come up from other packages.
I believe it has something to do with having two packages that require two different versions of another package but I'm not entirely sure.
Steps to reproduce
Link to minimal reproducible example (optional)
No response
The text was updated successfully, but these errors were encountered: