Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*_SLUG envs are not truncated #52

Closed
TomaszG opened this issue Sep 7, 2022 · 1 comment · Fixed by #53
Closed

*_SLUG envs are not truncated #52

TomaszG opened this issue Sep 7, 2022 · 1 comment · Fixed by #53
Assignees
Labels
enhancement New feature or request

Comments

@TomaszG
Copy link

TomaszG commented Sep 7, 2022

*_SLUG environment variables are commonly used as URLs or docker image tags. To make it happen without problems, a lot of systems also shorten them, e.g. GitLab's max length of SLUG is 63 bytes (https://docs.gitlab.com/ee/ci/variables/predefined_variables.html). Unfortunately, SLUG variables returned by this plugin are not shortened. Maybe it would be worth either:

  1. have a max length of SLUG predefined, or
  2. have a configuration option to define max SLUG length, or
  3. add a shortened version of SLUG env vars.
@TomaszG TomaszG changed the title *_SLUG envs are not shortened *_SLUG envs are not truncated Sep 7, 2022
@FranzDiebold FranzDiebold added the enhancement New feature or request label Sep 9, 2022
@FranzDiebold FranzDiebold self-assigned this Sep 9, 2022
@FranzDiebold FranzDiebold linked a pull request Sep 11, 2022 that will close this issue
@FranzDiebold
Copy link
Owner

Hi @TomaszG,

thanks for the issue and the idea!

I truncated all *_SLUG variables to 63 characters and published a new version v2.6.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants