Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: Cannot read property 'pull_request' of undefined #49

Closed
williarin opened this issue Jul 16, 2022 · 8 comments · Fixed by #51
Closed

Error: Cannot read property 'pull_request' of undefined #49

williarin opened this issue Jul 16, 2022 · 8 comments · Fixed by #51
Assignees
Labels
bug Something isn't working

Comments

@williarin
Copy link

The new release 2.5.0 seems to break on pull requests with this error:
Error: Cannot read property 'pull_request' of undefined

I haven't tried on master though.

Here's a failed job example: https://github.com/williarin/wordpress-interop/runs/7370315629?check_suite_focus=true#step:3:21

@yaldram
Copy link

yaldram commented Jul 16, 2022

Yes even I am getting this error. I used this variable - CI_PR_SHA_SHORT.

@FranzDiebold FranzDiebold self-assigned this Jul 17, 2022
@FranzDiebold FranzDiebold added the bug Something isn't working label Jul 17, 2022
@FranzDiebold
Copy link
Owner

Hi @williarin,
thanks for reporting this issue!

I removed version v2.5.0 and rolled back version v2.

So you can now use either version v2.4.0 or v2.

@yaldram
Copy link

yaldram commented Jul 17, 2022

@iamstarkov Sir can we fix the above error. I wanted to work with the CI_PR_SHA_SHORT variable. Thanks

@iamstarkov
Copy link
Contributor

@yaldram Sir we can, but not me in the next few days.

@yaldram
Copy link

yaldram commented Jul 17, 2022

@iamstarkov sure Sir take your time, thanks

@FranzDiebold
Copy link
Owner

Hi @williarin, @iamstarkov and @yaldram,

I have fixed the bug now and published a new version v2.5.0.

Can you confirm that CI_PR_SHA_SHORT and CI_PR_SHA are working now?

@FranzDiebold FranzDiebold linked a pull request Jul 17, 2022 that will close this issue
@yaldram
Copy link

yaldram commented Jul 18, 2022

@FranzDiebold Thanks a lot for fixing it Sir. It is working for me.

@FranzDiebold
Copy link
Owner

Sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants