Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose pull request id as CI_PR_NUMBER and CI_PR_ID #47

Merged
merged 4 commits into from Jul 7, 2022

Conversation

iamstarkov
Copy link
Contributor

Right now the closest this action offers CI_REF_NAME_SLUG which is 42-merge, but its not clean and more importantly cannot be used in numerical contexts which would benefit from having that as 42. if current event is not a pull-request, it should be empty

Right now the closest this action offers `CI_REF_NAME_SLUG` which is `42-merge`, but its not clean and more importantly cannot be used in numerical contexts which would benefit from having that as `42`. if current event is not a pull-request, it should be empty
@FranzDiebold FranzDiebold added the enhancement New feature or request label Jul 6, 2022
@iamstarkov
Copy link
Contributor Author

hmm, I can't see neither CI_PR_NUMBER nor CI_PR_ID printed in the demo workflows.

@iamstarkov
Copy link
Contributor Author

fixed

@FranzDiebold FranzDiebold self-assigned this Jul 7, 2022
@FranzDiebold
Copy link
Owner

@iamstarkov Thanks for the improvement! 👍

@FranzDiebold FranzDiebold merged commit dae1d34 into FranzDiebold:primary Jul 7, 2022
@iamstarkov iamstarkov deleted the feat/CI_PR_NUMBER branch July 11, 2022 08:43
@iamstarkov
Copy link
Contributor Author

@FranzDiebold happy to help out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants