Fix MSYS gcc meson build

[Framstag]

The MSYS gcc meson build currently fails. It looks like there is a problem during linking. However, I cannot reproduce the error locally and thus cannot fix it. I also get the warning regarding NOMINMAX locally, too.

Does anybody have an idea?

[45/355] Compiling C++ object libosmscout-map-gdi/libosmscout_map_gdi.dll.p/meson-generated_osmscout_map_gdi-unity0.cpp.obj
In file included from libosmscout-map-gdi/libosmscout_map_gdi.dll.p/osmscout_map_gdi-unity0.cpp:2:
D:/a/libosmscout/libosmscout/libosmscout-map-gdi/src/osmscoutmapgdi/MapPainterGDIWindow.cpp:26: warning: "NOMINMAX" redefined
   26 | #define NOMINMAX // msvc issue with std::max/min
      | 
In file included from D:/a/_temp/msys64/mingw64/include/c++/12.2.0/x86_64-w64-mingw32/bits/c++config.h:655,
                 from D:/a/_temp/msys64/mingw64/include/c++/12.2.0/cstdlib:41,
                 from D:/a/_temp/msys64/mingw64/include/c++/12.2.0/stdlib.h:36,
                 from D:/a/_temp/msys64/mingw64/lib/gcc/x86_64-w64-mingw32/12.2.0/include/mm_malloc.h:27,
                 from D:/a/_temp/msys64/mingw64/lib/gcc/x86_64-w64-mingw32/12.2.0/include/xmmintrin.h:34,
                 from D:/a/_temp/msys64/mingw64/lib/gcc/x86_64-w64-mingw32/12.2.0/include/immintrin.h:31,
                 from D:/a/_temp/msys64/mingw64/lib/gcc/x86_64-w64-mingw32/12.2.0/include/x86intrin.h:32,
                 from D:/a/_temp/msys64/mingw64/include/winnt.h:1658,
                 from D:/a/_temp/msys64/mingw64/include/minwindef.h:163,
                 from D:/a/_temp/msys64/mingw64/include/windef.h:9,
                 from D:/a/_temp/msys64/mingw64/include/windows.h:69,
                 from D:/a/libosmscout/libosmscout/libosmscout-map-gdi/src/osmscoutmapgdi/MapPainterGDI.cpp:28,
                 from libosmscout-map-gdi/libosmscout_map_gdi.dll.p/osmscout_map_gdi-unity0.cpp:1:
D:/a/_temp/msys64/mingw64/include/c++/12.2.0/x86_64-w64-mingw32/bits/os_defines.h:45: note: this is the location of the previous definition
   45 | #define NOMINMAX 1
      | 
[46/355] Compiling C++ object libosmscout-map-directx/libosmscout_map_directx.dll.p/meson-generated_osmscout_map_directx-unity0.cpp.obj
[47/355] Linking target libosmscout-map-directx/libosmscout_map_directx.dll
[48/355] Linking target libosmscout-map-gdi/libosmscout_map_gdi.dll
[49/355] Generating symbol file libosmscout-map-gdi/libosmscout_map_gdi.dll.p/libosmscout_map_gdi.dll.symbols
FAILED: libosmscout-map-gdi/libosmscout_map_gdi.dll.p/libosmscout_map_gdi.dll.symbols 
"D:/a/_temp/msys64/mingw64/bin/meson" "--internal" "symbolextractor" "D:/a/libosmscout/libosmscout/debug" libosmscout-map-gdi/libosmscout_map_gdi.dll "libosmscout-map-gdi/libosmscout_map_gdi.dll.a" libosmscout-map-gdi/libosmscout_map_gdi.dll.p/libosmscout_map_gdi.dll.symbols 
[50/355] Generating symbol file libosmscout-map-directx/libosmscout_map_directx.dll.p/libosmscout_map_directx.dll.symbols
[51/355] Compiling C++ object libosmscout-map-opengl/libosmscout_map_opengl.dll.p/meson-generated_osmscout_map_opengl-unity0.cpp.obj
ninja: build stopped: subcommand failed.

[eli-schwartz]

The MSYS gcc meson build currently fails. It looks like there is a problem during linking.

Close, but not exactly. Notice that the failing build edge is "generating symbol file", not "linking target".

It looks like this is another example of msys2/MINGW-packages#11864

Python bizarrely crashes sometimes, but seemingly only in Github Actions. It's not consistent, so retrying it will frequently succeed, and it cannot be easily debugged, because configuring JIT debugging causes the problem to vanish. On the other hand, that means that configuring JIT debugging works around the issue.

[Framstag]

Currently, all build works again. Closing this issue.