Resolves #1942: Make unrolled deletes the default record delete behavior #1943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…delete behavior This changes the default value in the property controlling whether record deletes are unrolled. Adopters can still opt into the old behavior by setting the property value, though most use cases should be fine with the new default. At some point in the future, we can consider deprecating the property and always unrolling record deletes if we wish. This resolves FoundationDB#1942.
|
Kudos, SonarCloud Quality Gate passed! |
Result of fdb-record-layer-pr-proto2 on Linux CentOS 7
|
Result of fdb-record-layer-pr-proto3 on Linux CentOS 7
|
MMcM
approved these changes
Dec 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the default value in the property controlling whether record deletes are unrolled. Adopters can still opt into the old behavior by setting the property value, though most use cases should be fine with the new default. At some point in the future, we can consider deprecating the property and always unrolling record deletes if we wish.
This resolves #1942.