Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make unrolled deletes the default record delete behavior #1942

Closed
alecgrieser opened this issue Dec 9, 2022 · 0 comments · Fixed by #1943
Closed

Make unrolled deletes the default record delete behavior #1942

alecgrieser opened this issue Dec 9, 2022 · 0 comments · Fixed by #1943
Assignees
@alecgrieser
Labels
performance Performance issues

Comments

@alecgrieser
Copy link
Contributor

Unrolled record deletes, added as an option in #1493, seem to be shown to outperform the old delete method, and so we should turn it on by default. The main way it outperforms the old behavior is that it allows the FDB client to consolidate a record update (which clears out the old record and then inserts the new one) into a minimal set of updates (i.e., clears over keys that are then overwritten are merged internally to just a single write). For storage engines for which small range deletes and point deletes have different performance characteristics, the change can be even more important.
@alecgrieser alecgrieser added the performance Performance issues label Dec 9, 2022
@alecgrieser alecgrieser self-assigned this Dec 9, 2022
alecgrieser added a commit to alecgrieser/fdb-record-layer that referenced this issue Dec 9, 2022
@alecgrieser
Resolves FoundationDB#1942: Make unrolled deletes the default record …
b24c60b 
…delete behavior

This changes the default value in the property controlling whether record deletes are unrolled. Adopters can still opt into the old behavior by setting the property value, though most use cases should be fine with the new default. At some point in the future, we can consider deprecating the property and always unrolling record deletes if we wish.

This resolves FoundationDB#1942.
@alecgrieser alecgrieser mentioned this issue Dec 9, 2022
Merged
@MMcM MMcM closed this as completed in #1943 Dec 9, 2022
MMcM added a commit that referenced this issue Dec 9, 2022
@MMcM
Merge pull request #1943 from alecgrieser/01942-unroll-by-default
d7a2687 
Resolves #1942: Make unrolled deletes the default record delete behavior
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alecgrieser alecgrieser

Labels
performance Performance issues
Projects
None yet
Milestone
No milestone
1 participant
@alecgrieser