add support for enum in deepCopyIfNeeded() in RecordConstructorValue

[g31pranjal]

…pCopyIfNeeded() in RecordConstructorValue)

[foundationdb-ci]

Result of fdb-record-layer-pr-proto2 on Linux CentOS 7

• Commit ID: af066ff
• Duration 0:16:59
• Result: ✅ SUCCEEDED
• Error: N/A
• Build Logs (available for 30 days)
• Build Artifact (available for 30 days)

[foundationdb-ci]

Result of fdb-record-layer-pr-proto3 on Linux CentOS 7

• Commit ID: af066ff
• Duration 0:17:40
• Result: ✅ SUCCEEDED
• Error: N/A
• Build Logs (available for 30 days)
• Build Artifact (available for 30 days)

[MMcM]

Is this sufficient? Doesn't the Descriptors.EnumValueDescriptor.getType need to match to target field descriptor in the same way as nested messages?

[hatyo]

Right, also, it seems there is a missing code path for handling enum fields in deepCopyMessageIfNeeded. To make sure this works as expected, I would suggest the following test:

enum Corpus {
  CORPUS_UNSPECIFIED = 0;
  CORPUS_UNIVERSAL = 1;
  CORPUS_WEB = 2;
  CORPUS_IMAGES = 3;
  CORPUS_LOCAL = 4;
  CORPUS_NEWS = 5;
  CORPUS_PRODUCTS = 6;
  CORPUS_VIDEO = 7;
}
message SearchRequest {
  string query = 1;
  int32 page_number = 2;
  int32 result_per_page = 3;
  Corpus corpus = 4;
}

case1: CORPUS_WEB against CORPUS_WEB

case2: 
  {"foo", 42, 100, CORPUS_LOCAL} against  {"foo", 42, 100, CORPUS_LOCAL}

another case for this message:

message SearchRequest {
  string query = 1;
  int32 page_number = 2;
  int32 result_per_page = 3;
  repeated Corpus corpus = 4;
}

 {"foo", 42, 100, [CORPUS_LOCAL]} against  {"foo", 42, 100, [CORPUS_LOCAL]}

I think the first case will hit this code path, but the second case will hit the (currently missing) handling of enum inside a message. The last case, will hit handling enum for repeated (array) fields.

[foundationdb-ci]

Result of fdb-record-layer-pr-proto2 on Linux CentOS 7

• Commit ID: 1e0a3e3
• Duration 0:16:19
• Result: ✅ SUCCEEDED
• Error: N/A
• Build Logs (available for 30 days)
• Build Artifact (available for 30 days)

[foundationdb-ci]

Result of fdb-record-layer-pr-proto3 on Linux CentOS 7

• Commit ID: 1e0a3e3
• Duration 0:17:41
• Result: ✅ SUCCEEDED
• Error: N/A
• Build Logs (available for 30 days)
• Build Artifact (available for 30 days)

[hatyo]

LGTM, very minor commits.

Please mark the deepCopyIfNeeded as @VisibleForTesting if the intention behind making it public was only to enable unit-testing it.

[sonarcloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
15 Code Smells

0.0% Coverage
0.0% Duplication

[foundationdb-ci]

Result of fdb-record-layer-pr-proto2 on Linux CentOS 7

• Commit ID: 7c09cb3
• Duration 0:16:45
• Result: ✅ SUCCEEDED
• Error: N/A
• Build Logs (available for 30 days)
• Build Artifact (available for 30 days)

[foundationdb-ci]

Result of fdb-record-layer-pr-proto3 on Linux CentOS 7

• Commit ID: 7c09cb3
• Duration 0:17:26
• Result: ✅ SUCCEEDED
• Error: N/A
• Build Logs (available for 30 days)
• Build Artifact (available for 30 days)

[hatyo]

Nice work!