Resolve #1710 UserVersionChecker should be getting RecordMetaDataProt… #1711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecgrieser
requested changes
Jun 3, 2022
...re/src/main/java/com/apple/foundationdb/record/provider/foundationdb/FDBRecordStoreBase.java
Show resolved
Hide resolved
...re/src/main/java/com/apple/foundationdb/record/provider/foundationdb/FDBRecordStoreBase.java
Show resolved
Hide resolved
AWS CodeBuild CI Report for Linux CentOS 7
|
AWS CodeBuild CI Report for Linux CentOS 7
|
sergey-mkhitaryan
force-pushed
the
check_user_version_store_header
branch
from
fec0165
to
9254dcf
Compare
alecgrieser
requested changes
Jun 3, 2022
...re/src/main/java/com/apple/foundationdb/record/provider/foundationdb/FDBRecordStoreBase.java
Show resolved
Hide resolved
AWS CodeBuild CI Report for Linux CentOS 7
|
AWS CodeBuild CI Report for Linux CentOS 7
|
…MetaDataProto.DataStoreInfo
sergey-mkhitaryan
force-pushed
the
check_user_version_store_header
branch
from
9254dcf
to
d72b4bd
Compare
alecgrieser
approved these changes
Jun 3, 2022
|
SonarCloud Quality Gate failed. |
AWS CodeBuild CI Report for Linux CentOS 7
|
AWS CodeBuild CI Report for Linux CentOS 7
|
alecgrieser
added a commit
to alecgrieser/fdb-record-layer
that referenced
this pull request
Jun 3, 2022
After FoundationDB#1711, there are some deprecation warnings that are breaking the build. This resolves the deprecation warnings by using the new API and marking the old one as deprecated in test code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…o.DataStoreInfo