Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support auto-complete via querying main Lucene directory #1682

Closed
alecgrieser opened this issue May 19, 2022 · 0 comments · Fixed by #1683
Closed

Support auto-complete via querying main Lucene directory #1682

alecgrieser opened this issue May 19, 2022 · 0 comments · Fixed by #1683
Assignees
@alecgrieser
Labels
enhancement New feature or request

Comments

@alecgrieser
Copy link
Contributor

At the moment, we support auto-complete in the Lucene indexes by adding a separate directory with auto-complete specific information. However, that has the disadvantage of requiring duplicate storage of the field and index data for auto-complete purposes. To save space, we should consider using the main Lucene directory as the search index for auto-complete, though this will have the disadvantage that it will require re-loading the original record and then extracting the text from it in order to support auto-complete, but that might still be worth it given the expense of these indexes.
@alecgrieser alecgrieser added the enhancement New feature or request label May 19, 2022
@alecgrieser alecgrieser self-assigned this May 19, 2022
@alecgrieser alecgrieser mentioned this issue May 19, 2022
Merged
alecgrieser added a commit to alecgrieser/fdb-record-layer that referenced this issue May 19, 2022
@alecgrieser
Resolves FoundationDB#1682: Support auto-complete via querying main L…
7a7d8bd 
…ucene directory

This modifies the auto-complete cursor so that it reads from the main Lucene index and then reconstitutes the original text by reading from the base record data.
alecgrieser added a commit to alecgrieser/fdb-record-layer that referenced this issue May 19, 2022
@alecgrieser
Resolves FoundationDB#1682: Support auto-complete via querying main L…
50a4cfc 
…ucene directory

This modifies the auto-complete cursor so that it reads from the main Lucene index and then reconstitutes the original text by reading from the base record data.
alecgrieser added a commit that referenced this issue May 25, 2022
@alecgrieser @jleach4
Resolves #1682: Support auto-complete via querying main Lucene direct…
606bfb8 
…ory (#1683)

* Current State is rough

* Resolves #1682: Support auto-complete via querying main Lucene directory

This modifies the auto-complete cursor so that it reads from the main Lucene index and then reconstitutes the original text by reading from the base record data.

Co-authored-by: john_leach <jleach4@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alecgrieser alecgrieser

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@alecgrieser