Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add .map variant to RecordCursor that supports changing a result's continuation #1663

Closed
alecgrieser opened this issue May 10, 2022 · 0 comments · Fixed by #1664
Closed

Add .map variant to RecordCursor that supports changing a result's continuation #1663

alecgrieser opened this issue May 10, 2022 · 0 comments · Fixed by #1664
Assignees
@alecgrieser
Labels
enhancement New feature or request

Comments

@alecgrieser
Copy link
Contributor

The .map method on a RecordCursor currently allows the user to modify the results returned by a record cursor, but the update can only change the value. There's not a variant that allows the user to update the result's continuation. This might be useful if, for example, the user wants to wrap the returned continuation in their own wrapping continuation (perhaps with additional context). The user does need to do a bit of work when resuming the cursor to extract the original continuation (or whatever alternative they want to go with), but it still seems like a useful feature to have.
@alecgrieser alecgrieser added the enhancement New feature or request label May 10, 2022
@alecgrieser alecgrieser self-assigned this May 10, 2022
alecgrieser added a commit to alecgrieser/fdb-record-layer that referenced this issue May 10, 2022
@alecgrieser
Resolves FoundationDB#1663: Add .map variant to RecordCursor that sup…
7b2c34d 
…ports changing a result's continuation

This adds a variant to `RecordCursor.map` that allows the caller to adjust the continuations returned by a `RecordCursor`. This would allow, for example, for someone to wrap the continuations with new data, or otherwise adjust the continuations returned.

This resolves FoundationDB#1663.
@alecgrieser alecgrieser mentioned this issue May 10, 2022
Merged
alecgrieser added a commit to alecgrieser/fdb-record-layer that referenced this issue May 16, 2022
@alecgrieser
Resolves FoundationDB#1663: Add .map variant to RecordCursor that sup…
051d42e 
…ports changing a result's continuation

This adds a variant to `RecordCursor.map` that allows the caller to adjust the continuations returned by a `RecordCursor`. This would allow, for example, for someone to wrap the continuations with new data, or otherwise adjust the continuations returned.

This resolves FoundationDB#1663.
alecgrieser added a commit to alecgrieser/fdb-record-layer that referenced this issue May 16, 2022
@alecgrieser
Resolves FoundationDB#1663: Add .map variant to RecordCursor that sup…
0017300 
…ports changing a result's continuation

This adds a variant to `RecordCursor.map` that allows the caller to adjust the continuations returned by a `RecordCursor`. This would allow, for example, for someone to wrap the continuations with new data, or otherwise adjust the continuations returned.

This resolves FoundationDB#1663.
ScottDugas added a commit that referenced this issue May 19, 2022
@ScottDugas
Merge pull request #1664 from alecgrieser/cursor-map-continuations
f0bda52 
Resolves #1663: Add .map variant to RecordCursor that supports changing a result's continuation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alecgrieser alecgrieser

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@alecgrieser