Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConcurrentModificationException when closing TransactionalRunner while calling run/runAsync #1659

Closed
ScottDugas opened this issue May 9, 2022 · 0 comments
Closed

ConcurrentModificationException when closing TransactionalRunner while calling run/runAsync #1659

ScottDugas opened this issue May 9, 2022 · 0 comments
Assignees
@ScottDugas

Comments

@ScottDugas
Copy link
Contributor

Sometimes, TransactionalRunnerTest.closesContextsSynchronous fails with

TransactionalRunnerTest > closesContextsSynchronous() FAILED
    java.util.ConcurrentModificationException
        at java.base/java.util.ArrayList.forEach(ArrayList.java:1543)
        at com.apple.foundationdb.record.provider.foundationdb.runners.TransactionalRunner.close(TransactionalRunner.java:174)
        at com.apple.foundationdb.record.provider.foundationdb.runners.TransactionalRunnerTest.closesContext(TransactionalRunnerTest.java:321)
        at com.apple.foundationdb.record.provider.foundationdb.runners.TransactionalRunnerTest.closesContextsSynchronous(TransactionalRunnerTest.java:286)
@ScottDugas ScottDugas self-assigned this May 9, 2022
@ScottDugas ScottDugas changed the title TransactionalRunnerTest.closesContextsSynchronous occasionally fails with ConcurrentModificationException ConcurrentModificationException when closing TransactionalRunner while calling run/runAsync May 9, 2022
ScottDugas added a commit to ScottDugas/fdb-record-layer that referenced this issue May 9, 2022
@ScottDugas
Fixes FoundationDB#1659: Add a missing synchronized keyword to Transa…
66e0043 
…ctionalRunner.close

This existed ot FDBDatabaseRunnerImpl, but not TransactionalRunner,
so closing at the same time as calling `run` can cause a
ConcurrentModificationException.
ScottDugas added a commit to ScottDugas/fdb-record-layer that referenced this issue May 9, 2022
@ScottDugas
Fixes FoundationDB#1659: Add a missing synchronized keyword to Transa…
fc0055c 
…ctionalRunner.close

This existed ot FDBDatabaseRunnerImpl, but not TransactionalRunner,
so closing at the same time as calling `run` can cause a
ConcurrentModificationException.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ScottDugas ScottDugas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ScottDugas