From 9ef36e6b7c16a20a7107c5b55beb1fa93817471c Mon Sep 17 00:00:00 2001
From: Ollie Etherington <ollie@etherington.xyz>
Date: Wed, 4 Oct 2023 12:15:18 +0300
Subject: [PATCH] Skip mirroring images with invalid URLs

---
 .../server/scripts/convertImagesToCloudinary.ts        | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/packages/lesswrong/server/scripts/convertImagesToCloudinary.ts b/packages/lesswrong/server/scripts/convertImagesToCloudinary.ts
index b381e225dd3..6887617b450 100644
--- a/packages/lesswrong/server/scripts/convertImagesToCloudinary.ts
+++ b/packages/lesswrong/server/scripts/convertImagesToCloudinary.ts
@@ -88,11 +88,15 @@ function getImageUrlWhitelist() {
 }
 
 function urlNeedsMirroring(url: string, filterFn: (url: string) => boolean) {
-  const parsedUrl = new URL(url);
-  if (getImageUrlWhitelist().indexOf(parsedUrl.hostname) !== -1) {
+  try {
+    const parsedUrl = new URL(url);
+    if (getImageUrlWhitelist().indexOf(parsedUrl.hostname) !== -1) {
+      return false;
+    }
+    return filterFn(url);
+  } catch (e) {
     return false;
   }
-  return filterFn(url);
 }
 
 async function convertImagesInHTML(html: string, originDocumentId: string, urlFilterFn: (url: string) => boolean = () => true): Promise<{count: number, html: string}> {