Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: "Success" status overwritten and stuck in "Compiling" for finished webpack build. #321

Closed
SoxPan opened this issue Jan 25, 2021 · 2 comments · Fixed by #322
Closed

Comments

@SoxPan
Copy link

SoxPan commented Jan 25, 2021

Please provide a description of the bug / issue, and provide the details below:

Progress is 100% but status is still Compiling

If the issue is visual, please provide screenshots here

Screen Shot 2021-01-25 at 9 14 31 PM

====================================================================
Steps to reproduce the problem

Just running webpack-dashboard --minimal -- webpack --config webpack.config.js command

Please provide a gist of relevant files
  1. https://gist.github.com/SoxPan/138cec681ab71e2219f60468c5b58dcb
  2. https://gist.github.com/SoxPan/6e064d6d7ee301497d734e56b475c4b7
More Details
  • What operating system are you on? MacOS Big Sur
  • What terminal application are you using? MacOS Terminal
  • What version of webpack-dashboard are you using? 3.3.0
  • What is the output of running echo $TERM? xterm-256color
@ryan-roemer
Copy link
Member

ryan-roemer commented Jan 25, 2021

Update: Nevermind, I misread the issue. We're investigating 😛

@ryan-roemer
Copy link
Member

ryan-roemer commented Jan 26, 2021

Confirmed. At least in webpack5 there's some incorrect interplay with webpack.ProgressPlugin reporting more status after hooks.done fires. Debug logs for our repo dev command yarn dev:

TODO webpack.ProgressPlugin  status: 'Compiling', percent: 0.95, msg: 'emitting' 
TODO webpack.ProgressPlugin  status: 'Compiling', percent: 0.98, msg: 'emitting' 
TODO webpack.ProgressPlugin  status: 'Compiling', percent: 0.98, msg: 'emitting' 
TODO webpack.ProgressPlugin  status: 'Compiling', percent: 0.99, msg: 'done'     
TODO webpack.ProgressPlugin  status: 'Compiling', percent: 0.99, msg: 'done'     
TODO hook.done  status: 'Success'         
# ... webpack stuff snipped ...                                       
TODO webpack.ProgressPlugin  status: 'Compiling', percent: 0.99, msg: 'done'     
TODO webpack.ProgressPlugin  status: 'Compiling', percent: 0.99, msg: ''         
TODO webpack.ProgressPlugin  status: 'Compiling', percent: 0.99, msg: 'cache' 
TODO webpack.ProgressPlugin  status: 'Compiling', percent: 0.99, msg: 'cache' 
TODO webpack.ProgressPlugin  status: 'Compiling', percent: 0.99, msg: 'cache' 
TODO webpack.ProgressPlugin  status: 'Compiling', percent: 0.99, msg: 'cache' 
TODO webpack.ProgressPlugin  status: 'Compiling', percent: 1, msg: ''         

We can probably use some threshold of percent and/or just straight msg to special case not having ProgressPlugin overwrite a Success (or possibly other) status.

@ryan-roemer ryan-roemer changed the title Is not showing that compiling was finished Bug: "Success" status overwritten and stuck in "Compiling" for finished webpack build. Jan 26, 2021
ryan-roemer added a commit that referenced this issue Jan 29, 2021
…322)

- Ensure a finished compilation state (failed, error, success) isn't overwritten by the ProgressPlugin. Fixes #321 
- Add error status inferred from webpack stats.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants