New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: Straight webpack build (without watch) does not reach final state. #294
Comments
always loading,because of the use of |
Thanks for the report. Can you try two things to help us identify the issue:
Thanks! |
I had a similar issue on I have found that changing:
to this:
resolved the issue for me. |
@ryan-roemer Hello. I have the same problem. Is there a solution? |
I found that downgrading to 3.0.7 is good.The latest version still has the problem. |
@tanrich I'm happy to jump in and diagnose if there's a reproduction. Can you make a minimal GitHub repository with installation instructions and instructions of the commands you are running in the terminal with |
I had a similar issue on Code: https://github.com/peterhpchen/book-webpack-examples/tree/develop/v4/27-production-analyze/dashboard-demo (It has issue after upgrade to Thank you. |
Thanks @peterhpchen ! Verified an issue reproduction with your project. We'll dig in from here now that we have a repro. Note that the screenshot I have below is not the original issue in that we don't have the Notes: From "scripts": {
"build": "webpack-dashboard -- webpack"
},
"devDependencies": {
"webpack": "^4.44.2",
"webpack-cli": "^3.3.12",
"webpack-dashboard": "^3.3.3"
} we get: |
Thanks, @ryan-roemer . Just a reminder that webpack v5 has the same issue in Thank you. |
@peterhpchen -- On further inspection, one issue I'm noticing in the repo is that it's doing I'm still going to investigate, but the following works just fine for diff --git a/v4/27-production-analyze/dashboard-demo/package.json b/v4/27-production-analyze/dashboard-demo/package.json
index 5963133..5139015 100644
--- a/v4/27-production-analyze/dashboard-demo/package.json
+++ b/v4/27-production-analyze/dashboard-demo/package.json
@@ -4,11 +4,11 @@
"main": "index.js",
"license": "MIT",
"scripts": {
- "build": "webpack-dashboard -- webpack"
+ "build": "webpack-dashboard -- webpack --watch"
},
"devDependencies": {
"webpack": "^4.44.2",
"webpack-cli": "^3.3.12",
- "webpack-dashboard": "^3.2.1"
+ "webpack-dashboard": "^3.3.3"
}
} |
Refactors the plugin internal logic to be a lot simpler. - Chore: Refactor internal stats consumption to perform `inspectpack` analysis in the main thread, without using `main` streams. Originally, the `inspectpack` engine did some really heavy CPU stuff (gzipping lots of files), but now the actions are super fast, so I've removed `most` async observables and just switched to straight promises. - Chore: Refactor internal handler in plugin to always be a wrapped function so that we can't accidentally have asynchronous code call the handler function after it is removed / nulled. - Bugfix: Add message counting delayed cleanup in plugin to allow messages to drain in Dashboard. The issue seems to be that we hit socket IO disconnect in the plugin before the dashboard actually processes the messages. Fixes #294.
The text was updated successfully, but these errors were encountered: