Feature: Enable opt-out of minified, gzip calculations. #230

ryan-roemer · 2018-01-22T23:38:08Z

Overview

This PR adds minified and gzip configuration options that can optionally disable the relatively expensive per-module calculations of each by inspectpack under the hood.

Fixes multiple node progress in Activity Monitor #227
Adds minified and gzip plugin options, both defaulted to true so we don't need a semver major bump.
Adds more README documentation and explanations about CPU intensive workloads and the inspectpack cache.

/cc @kenwheeler @tptee

Sample Results

I took a previous project opened for bug diagnosis with a reasonably-sized app, and compared outputs, stats and execution times:

(Baseline) `master`

┌──Modules───────────────────────────────────────────────────────────────────────────────────────────┐┌──Assets────────────────────────────────────────────────────────────────────────────────────────────┐
│                                                                                                    ││                                                                                                    │
│   1:vendor.js    2:app.js    3:style.js    4:polyfills.js    5:vendorDll.dll.js    6:polyfills.dll ││                                                                                                    │
│                                                                                                    ││  Name                                           Size                                               │
│  Name                                     Size (min+gz)               Percentage                   ││                                                                                                    │
│                                                                                                    ││                                                                                                    │
│                                                                                                    ││  style.js.map                                   606 B                                              │
│  sockjs-client                            24.7 KB                     41.4%                        ││                                                                                                    │
│                                                                                                    ││                                                                                                    │
│                                                                                                    ││  vendor.js                                      635 B (min+gz)                                     │
│  html-entities                            14.46 KB                    24.2%                        ││                                                                                                    │
│                                                                                                    ││                                                                                                    │
│                                                                                                    ││  style.js                                       235 B (min+gz)                                     │
│  json3                                    3.35 KB                     5.61%                        ││                                                                                                    │
│                                                                                                    ││                                                                                                    │
│                                                                                                    │└────────────────────────────────────────────────────────────────────────────────────────────────────┘
│  url                                      2.89 KB                     4.83%                        │┌─Problems───────────────────────────────────────────────────────────────────────────────────────────┐
│                                                                                                    ││                                                                                                    │
│                                                                                                    ││  1:vendor.js    2:app.js    3:style.js    4:polyfills.js    5:vendorDll.dll.js    6:polyfills.dll.j│
│  (webpack)-dev-server                     2.26 KB                     3.79%                        ││                                                                                                    │
│                                                                                                    ││  No problems detected!                                                                             │
│                                                                                                    ││                                                                                                    │
│  url-parse                                1.76 KB                     2.95%                        ││                                                                                                    │
│                                                                                                    ││                                                                                                    │
│                                                                                                    ││                                                                                                    │
│  debug                                    1.56 KB                     2.61%                        ││                                                                                                    │
│                                                                                                    ││                                                                                                    │
│                                                                                                    ││                                                                                                    │
│  (webpack)                                1.48 KB                     2.48%                        ││                                                                                                    │
│                                                                                                    ││                                                                                                    │
│                                                                                                    ││                                                                                                    │
│  punycode                                 1.36 KB                     2.27%                        ││                                                                                                    │
│                                                                                                    ││                                                                                                    │
│                                                                                                    ││                                                                                                    │
│  events                                   1.11 KB                     1.86%                        ││                                                                                                    │
│                                                                                                    ││                                                                                                    │
│                                                                                                    ││                                                                                                    │
└────────────────────────────────────────────────────────────────────────────────────────────────────┘└────────────────────────────────────────────────────────────────────────────────────────────────────┘

no optimizations

Setting: "minified":false,"gzip":false
Uncached time for sizes calculation: 12615 ms
Cached time for sizes calculation: 2555 ms

┌──Modules───────────────────────────────────────────────────────────────────────────────────────────┐┌──Assets────────────────────────────────────────────────────────────────────────────────────────────┐
│                                                                                                    ││                                                                                                    │
│   1:vendor.js    2:app.js    3:style.js    4:polyfills.js    5:vendorDll.dll.js    6:polyfills.dll ││                                                                                                    │
│                                                                                                    ││  Name                                               Size                                           │
│  Name                                       Size                      Percentage                   ││                                                                                                    │
│                                                                                                    ││                                                                                                    │
│                                                                                                    ││  style.js.map                                       606 B                                          │
│  sockjs-client                              117.95 KB                 35.9%                        ││                                                                                                    │
│                                                                                                    ││                                                                                                    │
│                                                                                                    ││  vendor.js                                          34.42 KB                                       │
│  html-entities                              57.87 KB                  17.6%                        ││                                                                                                    │
│                                                                                                    ││                                                                                                    │
│                                                                                                    ││  style.js                                           1.71 KB                                        │
│  json3                                      42.94 KB                  13.1%                        ││                                                                                                    │
│                                                                                                    ││                                                                                                    │
│                                                                                                    │└────────────────────────────────────────────────────────────────────────────────────────────────────┘
│  url                                        23.36 KB                  7.11%                        │┌─Problems───────────────────────────────────────────────────────────────────────────────────────────┐
│                                                                                                    ││                                                                                                    │
│                                                                                                    ││  1:vendor.js    2:app.js    3:style.js    4:polyfills.js    5:vendorDll.dll.js    6:polyfills.dll.j│
│  punycode                                   14.82 KB                  4.51%                        ││                                                                                                    │
│                                                                                                    ││  No problems detected!                                                                             │
│                                                                                                    ││                                                                                                    │
│  url-parse                                  13.05 KB                  3.97%                        ││                                                                                                    │
│                                                                                                    ││                                                                                                    │
│                                                                                                    ││                                                                                                    │
│  (webpack)-dev-server                       12.55 KB                  3.82%                        ││                                                                                                    │
│                                                                                                    ││                                                                                                    │
│                                                                                                    ││                                                                                                    │
│  debug                                      9.33 KB                   2.84%                        ││                                                                                                    │
│                                                                                                    ││                                                                                                    │
│                                                                                                    ││                                                                                                    │
│  events                                     8.17 KB                   2.49%                        ││                                                                                                    │
│                                                                                                    ││                                                                                                    │
│                                                                                                    ││                                                                                                    │
│  loglevel                                   7.99 KB                   2.43%                        ││                                                                                                    │
│                                                                                                    ││                                                                                                    │
│                                                                                                    ││                                                                                                    │
└────────────────────────────────────────────────────────────────────────────────────────────────────┘└────────────────────────────────────────────────────────────────────────────────────────────────────┘

min

Setting: "minified":true,"gzip":false
Uncached time for sizes calculation: 65875 ms
Cached time for sizes calculation: 2270 ms

┌──Modules───────────────────────────────────────────────────────────────────────────────────────────┐┌──Assets────────────────────────────────────────────────────────────────────────────────────────────┐
│                                                                                                    ││                                                                                                    │
│   1:vendor.js    2:app.js    3:style.js    4:polyfills.js    5:vendorDll.dll.js    6:polyfills.dll ││                                                                                                    │
│                                                                                                    ││  Name                                            Size                                              │
│  Name                                      Size (min)                Percentage                    ││                                                                                                    │
│                                                                                                    ││                                                                                                    │
│                                                                                                    ││  style.js.map                                    606 B                                             │
│  sockjs-client                             52.74 KB                  36.8%                         ││                                                                                                    │
│                                                                                                    ││                                                                                                    │
│                                                                                                    ││  vendor.js                                       3.31 KB (min)                                     │
│  html-entities                             46.39 KB                  32.4%                         ││                                                                                                    │
│                                                                                                    ││                                                                                                    │
│                                                                                                    ││  style.js                                        360 B (min)                                       │
│  json3                                     7.9 KB                    5.52%                         ││                                                                                                    │
│                                                                                                    ││                                                                                                    │
│                                                                                                    │└────────────────────────────────────────────────────────────────────────────────────────────────────┘
│  url                                       7.62 KB                   5.32%                         │┌─Problems───────────────────────────────────────────────────────────────────────────────────────────┐
│                                                                                                    ││                                                                                                    │
│                                                                                                    ││  1:vendor.js    2:app.js    3:style.js    4:polyfills.js    5:vendorDll.dll.js    6:polyfills.dll.j│
│  (webpack)-dev-server                      4.82 KB                   3.37%                         ││                                                                                                    │
│                                                                                                    ││  No problems detected!                                                                             │
│                                                                                                    ││                                                                                                    │
│  url-parse                                 3.63 KB                   2.54%                         ││                                                                                                    │
│                                                                                                    ││                                                                                                    │
│                                                                                                    ││                                                                                                    │
│  events                                    3.48 KB                   2.43%                         ││                                                                                                    │
│                                                                                                    ││                                                                                                    │
│                                                                                                    ││                                                                                                    │
│  debug                                     3.08 KB                   2.15%                         ││                                                                                                    │
│                                                                                                    ││                                                                                                    │
│                                                                                                    ││                                                                                                    │
│  (webpack)                                 2.59 KB                   1.81%                         ││                                                                                                    │
│                                                                                                    ││                                                                                                    │
│                                                                                                    ││                                                                                                    │
│  punycode                                  2.54 KB                   1.77%                         ││                                                                                                    │
│                                                                                                    ││                                                                                                    │
│                                                                                                    ││                                                                                                    │
└────────────────────────────────────────────────────────────────────────────────────────────────────┘└────────────────────────────────────────────────────────────────────────────────────────────────────┘

min+gz

Setting: "minified":true,"gzip":true
Uncached time for sizes calculation: 82141 ms
Cached time for sizes calculation: 2671 ms

┌──Modules───────────────────────────────────────────────────────────────────────────────────────────┐┌──Assets────────────────────────────────────────────────────────────────────────────────────────────┐
│                                                                                                    ││                                                                                                    │
│   1:vendor.js    2:app.js    3:style.js    4:polyfills.js    5:vendorDll.dll.js    6:polyfills.dll ││                                                                                                    │
│                                                                                                    ││  Name                                           Size                                               │
│  Name                                     Size (min+gz)               Percentage                   ││                                                                                                    │
│                                                                                                    ││                                                                                                    │
│                                                                                                    ││  style.js.map                                   606 B                                              │
│  sockjs-client                            24.7 KB                     41.4%                        ││                                                                                                    │
│                                                                                                    ││                                                                                                    │
│                                                                                                    ││  vendor.js                                      635 B (min+gz)                                     │
│  html-entities                            14.46 KB                    24.2%                        ││                                                                                                    │
│                                                                                                    ││                                                                                                    │
│                                                                                                    ││  style.js                                       235 B (min+gz)                                     │
│  json3                                    3.35 KB                     5.61%                        ││                                                                                                    │
│                                                                                                    ││                                                                                                    │
│                                                                                                    │└────────────────────────────────────────────────────────────────────────────────────────────────────┘
│  url                                      2.89 KB                     4.83%                        │┌─Problems───────────────────────────────────────────────────────────────────────────────────────────┐
│                                                                                                    ││                                                                                                    │
│                                                                                                    ││  1:vendor.js    2:app.js    3:style.js    4:polyfills.js    5:vendorDll.dll.js    6:polyfills.dll.j│
│  (webpack)-dev-server                     2.26 KB                     3.79%                        ││                                                                                                    │
│                                                                                                    ││  No problems detected!                                                                             │
│                                                                                                    ││                                                                                                    │
│  url-parse                                1.76 KB                     2.95%                        ││                                                                                                    │
│                                                                                                    ││                                                                                                    │
│                                                                                                    ││                                                                                                    │
│  debug                                    1.56 KB                     2.61%                        ││                                                                                                    │
│                                                                                                    ││                                                                                                    │
│                                                                                                    ││                                                                                                    │
│  (webpack)                                1.48 KB                     2.48%                        ││                                                                                                    │
│                                                                                                    ││                                                                                                    │
│                                                                                                    ││                                                                                                    │
│  punycode                                 1.36 KB                     2.27%                        ││                                                                                                    │
│                                                                                                    ││                                                                                                    │
│                                                                                                    ││                                                                                                    │
│  events                                   1.11 KB                     1.86%                        ││                                                                                                    │
│                                                                                                    ││                                                                                                    │
│                                                                                                    ││                                                                                                    │
└────────────────────────────────────────────────────────────────────────────────────────────────────┘└────────────────────────────────────────────────────────────────────────────────────────────────────┘

kenwheeler · 2018-01-23T01:45:01Z

This is dank!

ryan-roemer · 2018-01-23T16:41:56Z

Released in webpack-dashboard@1.1.0

Notes: https://github.com/FormidableLabs/webpack-dashboard/releases/tag/v1.1.0

ryan-roemer added 7 commits January 22, 2018 12:33

WIP: Start unwinding minGz assumption.

9c7dcae

WIP: More extraction of min+gz assumption

f1cc9b2

WIP: Expand most handling of min+gz with options.

39d7fb4

More unwinding of stats

bd8fd08

Fix ordering.

f2aded3

Mostly final cleanup

4c0ff61

Add cache notes

127154d

ryan-roemer mentioned this pull request Jan 22, 2018

multiple node progress in Activity Monitor #227

Closed

ryan-roemer requested a review from kenwheeler January 22, 2018 23:40

ryan-roemer changed the title ~~Feature/opt in inspectpack~~ Feature: Enable opt-out of minified, gzip calculations. Jan 22, 2018

kenwheeler approved these changes Jan 23, 2018

View reviewed changes

ryan-roemer merged commit 7f99b31 into master Jan 23, 2018

ryan-roemer deleted the feature/opt-in-inspectpack branch January 23, 2018 16:38

This was referenced Jan 23, 2018

TypeError: Cannot read property 'full' of undefined / Worker error Error: No code sections found #231

Closed

Bug: Allow better fallback for real metrics. #232

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature: Enable opt-out of minified, gzip calculations. #230

Feature: Enable opt-out of minified, gzip calculations. #230

ryan-roemer commented Jan 22, 2018

kenwheeler commented Jan 23, 2018

ryan-roemer commented Jan 23, 2018

Feature: Enable opt-out of minified, gzip calculations. #230

Feature: Enable opt-out of minified, gzip calculations. #230

Conversation

ryan-roemer commented Jan 22, 2018

Overview

Sample Results

(Baseline) master

no optimizations

min

min+gz

kenwheeler commented Jan 23, 2018

ryan-roemer commented Jan 23, 2018

(Baseline) `master`