Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visitor callback element argument is typed incorrectly in TypeScript #86

Open
TheSonOfThomp opened this issue Apr 21, 2023 · 0 comments · May be fixed by #87
Open

Visitor callback element argument is typed incorrectly in TypeScript #86

TheSonOfThomp opened this issue Apr 21, 2023 · 0 comments · May be fixed by #87

Comments

@TheSonOfThomp
Copy link

The Flow type definition of the element argument is found in src/element.js:

export type UserElement = {
  type: ComponentType<DefaultProps> & ComponentStatics,
  props: DefaultProps,
  $$typeof: typeof REACT_ELEMENT_TYPE
}

In scripts/react-ssr-prepass.d.ts this type is mapped to React.ElementType<any>. However, the type defined above more accurately would be mapped to React.ReactElement<any> (see @types/react)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updates element argument type in react-ssr-prepass.d.ts TheSonOfThomp/react-ssr-prepass
1 participant
@TheSonOfThomp