Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contributing guidelines, add a PR template #72

Merged
merged 4 commits into from May 4, 2020

Conversation

kale-stew
Copy link
Contributor

This PR introduces a default template for all incoming PRs, so contributors have a better understanding of steps they need to adhere to to have their work merged.

It also updates the steps we've outlined in our Contributing doc based on my own experience contributing to this library earlier today. :-)

Copy link
Member

@ryan-roemer ryan-roemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! I have some suggestions from a preliminary review for a little reorg and such

.github/pull_request_template.md Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
Copy link
Contributor

@chrisbolin chrisbolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. just two things to fix in the comments:

  • remove extra line breaks in bulleted list
  • remove the 's from fast-deep-equal

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@kale-stew kale-stew merged commit 271b81b into master May 4, 2020
@kale-stew kale-stew deleted the docs/contributing branch May 4, 2020 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants