Update github.js #100
Update github.js #100
Conversation
more closer match to github theme
|
Hiya 👋 this is some amazing work! Do you have a short description or summary of how you arrived on some of the changes, even if some of it may just come down to matching some discrepancies manually? |
|
I working on my project which came across to use this github theme. Somehow I find it not really matching with the current github theme. Therefore, to fulfill the need in my project, I updated this github theme accordingly. |
more closer match to github theme Co-authored-by: Phil Pluckthun <phil@kitten.sh>
more closer match to github theme Co-authored-by: Phil Pluckthun <phil@kitten.sh>
|
It would have been nice to not remove all kinds of general token (e.g. string, symbol, namespace) classes, but instead update their styles. This completely broke some of my custom language definitions after updating... |
…ax highlighting closes #561 Syntax highlighting broke because docusaurus updated prism and that resulted in FormidableLabs/prism-react-renderer#100 being propagated which in turn removed some of the token classes we used. Added a custom theme to avoid that in the future.
|
Note that this change causes serious regression, for example, just compare syntax highlighting for HTML: Due to the high color contrast, the code is difficult to read.
Moreover, this doesn't match GitHub's color scheme, since it should be as on screenshot below:
Apparently not only I faced such problem, other people are also forced to rollback "prism-react-renderer" to the previous "stable" version (1.1.1) |
|
I've reverted this PR for now until I can check which changes from it are save to pick over: 0040cd4 |
|
In fact, @krsntn probably used dark mode when doing this. Maybe move this to a separate theme instead? Maybe he can clarify how he came up with this? |
more closer match to github theme