{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":205042606,"defaultBranch":"master","name":"msbuild","ownerLogin":"Forgind","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2019-08-28T23:44:38.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/12969783?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1715031724.0","currentOid":""},"activityList":{"items":[{"before":"4e4fa699f8f8643e0fcde0b40ebcf8a5f76a9d46","after":null,"ref":"refs/heads/workload-sdk-load-failures","pushedAt":"2024-05-06T21:42:04.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"Forgind","name":null,"path":"/Forgind","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12969783?s=80&v=4"}},{"before":null,"after":"4e4fa699f8f8643e0fcde0b40ebcf8a5f76a9d46","ref":"refs/heads/workload-sdk-load-failures","pushedAt":"2024-05-06T17:26:08.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"Forgind","name":null,"path":"/Forgind","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12969783?s=80&v=4"},"commit":{"message":"Maybe permit failed SDK load\n\nIf an SDK is a workload SDK, and we don't have the workload SDK resolver from the SDK, as, for instance, if we have an xcopy'd MSBuild, then we should still be able to build simple projects that don't require workloads. Right now, we just fail. If we get into a failure state, this tries to figure out if we actually need workloads, erring on the side of failing if we aren't sure. If we decide we don't need workloads, however, we suppress the error for failing to load a workload SDK.\n\nFixes #7988","shortMessageHtmlLink":"Maybe permit failed SDK load"}},{"before":null,"after":"c7696e4d042fdfa780332422838e1402f9bd6bae","ref":"refs/heads/tweak-message","pushedAt":"2024-03-19T16:31:23.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"Forgind","name":null,"path":"/Forgind","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12969783?s=80&v=4"},"commit":{"message":"Proposed rewording","shortMessageHtmlLink":"Proposed rewording"}},{"before":"50c0870129f92fe66229ebe4e7ed607ebdcd0b85","after":null,"ref":"refs/heads/add-output-to-file-option","pushedAt":"2024-02-28T17:15:05.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"Forgind","name":null,"path":"/Forgind","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12969783?s=80&v=4"}},{"before":"a7793c5c30fdbfb8a323746b8a9536aa277d11e6","after":"50c0870129f92fe66229ebe4e7ed607ebdcd0b85","ref":"refs/heads/add-output-to-file-option","pushedAt":"2024-02-23T21:39:22.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Forgind","name":null,"path":"/Forgind","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12969783?s=80&v=4"},"commit":{"message":"pr feedback","shortMessageHtmlLink":"pr feedback"}},{"before":"a2b928c15da1a48f1ef5e6f4e11601fecd3dd849","after":"a7793c5c30fdbfb8a323746b8a9536aa277d11e6","ref":"refs/heads/add-output-to-file-option","pushedAt":"2024-02-23T14:37:18.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"Forgind","name":null,"path":"/Forgind","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12969783?s=80&v=4"},"commit":{"message":"Merge branch 'add-output-to-file-option' of https://github.com/Forgind/msbuild into add-output-to-file-option","shortMessageHtmlLink":"Merge branch 'add-output-to-file-option' of <a href=\"https://github.com/Forgind/msbuild\">https://github.com/Forgin…</a>"}},{"before":"4ae5f8f1491d47c4b2125584e6e093e925a4292f","after":"a2b928c15da1a48f1ef5e6f4e11601fecd3dd849","ref":"refs/heads/add-output-to-file-option","pushedAt":"2024-02-20T16:32:57.000Z","pushType":"push","commitsCount":142,"pusher":{"login":"Forgind","name":null,"path":"/Forgind","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12969783?s=80&v=4"},"commit":{"message":"Merge branch 'main' into add-output-to-file-option","shortMessageHtmlLink":"Merge branch 'main' into add-output-to-file-option"}},{"before":"9ae833e5fc229f521fc017d0ece4b9353289d699","after":"299e0514835a1588e6ef21b1da748462dec706b8","ref":"refs/heads/master","pushedAt":"2024-02-13T14:06:32.000Z","pushType":"push","commitsCount":443,"pusher":{"login":"Forgind","name":null,"path":"/Forgind","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12969783?s=80&v=4"},"commit":{"message":"Optimize SDK resolution in dotnet build (#9657)\n\nFixes #9506\r\n\r\n### Context\r\n\r\nIn `dotnet build`, resolving in-box Sdk's has suboptimal performance. Resolver assemblies are loaded into the process even in cases where the project asks for Sdk's like `Microsoft.NET.Sdk`, which can be looked up trivially. And in fact, they are looked up trivially but only after resolver assemblies have been loaded and invoked.\r\n\r\nThe inefficiency is shown by the recently added logging:\r\n\r\n![image](https://github.com/dotnet/msbuild/assets/12206368/bc3fb867-df4a-46cd-81b4-07e33b2992a2)\r\n\r\nThere is also a subtle and confusing functional difference between `MSBuild.exe` and `dotnet build` where a NuGet package may take precedence over an in-box Sdk in `dotnet build`, but the same is not possible in `MSBuild.exe`.\r\n\r\n### Changes Made\r\n\r\nMade the default resolver handle the Sdk resolution first, before external resolvers are consulted. This is better perf-wise and aligns with `MSBuild.exe`, please see the large code comment for details.\r\n\r\nThis eliminates all but the last log event: `The SDK \"Microsoft.NET.Sdk\" was successfully resolved by the \"DefaultSdkResolver\" resolver to location \"C:\\Program Files\\dotnet\\sdk\\9.0.100-alpha.1.24067.2\\Sdks\\Microsoft.NET.Sdk\\Sdk\" and version \"\".`\r\n\r\n### Testing\r\n\r\nExisting and new unit tests, manual testing of various builds.\r\n\r\nPerf testing: `dotnet build` that builds a project depending on in-box Sdks is ~10 ms faster and loads 5 fewer assemblies, as long as it's built with `MSBuildEnableWorkloadResolver=false` (see below).\r\n\r\n### Notes\r\n\r\nWhile we don't have to ask the `MSBuildWorkloadSdkResolver` and `NuGetSdkResolver` to resolve in-box Sdk's anymore, this change is unfortunately not avoiding these resolvers in most builds. They are still loaded to resolve the special `Microsoft.NET.SDK.WorkloadAutoImportPropsLocator` Sdk, unless workloads are disabled.","shortMessageHtmlLink":"Optimize SDK resolution in dotnet build (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2087070080\" data-permission-text=\"Title is private\" data-url=\"https://github.com/dotnet/msbuild/issues/9657\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/dotnet/msbuild/pull/9657/hovercard\" href=\"https://github.com/dotnet/msbuild/pull/9657\">dotnet#9657</a>)"}},{"before":"863b65b854ffef6a355fdb3ea9bd8767b38fc52a","after":null,"ref":"refs/heads/targetResults-optimizations","pushedAt":"2024-02-01T00:40:05.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"Forgind","name":null,"path":"/Forgind","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12969783?s=80&v=4"}},{"before":"113d2d3618cd8dd82ee00c68a03c0073d0998b60","after":"863b65b854ffef6a355fdb3ea9bd8767b38fc52a","ref":"refs/heads/targetResults-optimizations","pushedAt":"2024-01-26T01:07:31.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Forgind","name":null,"path":"/Forgind","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12969783?s=80&v=4"},"commit":{"message":"Give targetOutputItems an initial value","shortMessageHtmlLink":"Give targetOutputItems an initial value"}},{"before":"f27bff3e02b8156f7400483094b6c64606ba86af","after":"4ae5f8f1491d47c4b2125584e6e093e925a4292f","ref":"refs/heads/add-output-to-file-option","pushedAt":"2024-01-19T01:11:20.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Forgind","name":null,"path":"/Forgind","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12969783?s=80&v=4"},"commit":{"message":"Capture bool check","shortMessageHtmlLink":"Capture bool check"}},{"before":"34942539e59a38c664ecce5df0f6aca7c73fac3b","after":"f27bff3e02b8156f7400483094b6c64606ba86af","ref":"refs/heads/add-output-to-file-option","pushedAt":"2024-01-16T23:39:25.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Forgind","name":null,"path":"/Forgind","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12969783?s=80&v=4"},"commit":{"message":"Flush","shortMessageHtmlLink":"Flush"}},{"before":"400c9e8ffd014381f015cde916dbc3d752dd638c","after":"d588b65dddde0023d299aeda18ff7885d404d921","ref":"refs/heads/log-before-unregistering","pushedAt":"2024-01-16T19:17:49.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Forgind","name":null,"path":"/Forgind","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12969783?s=80&v=4"},"commit":{"message":"Log error message + low pri stack","shortMessageHtmlLink":"Log error message + low pri stack"}},{"before":null,"after":"34942539e59a38c664ecce5df0f6aca7c73fac3b","ref":"refs/heads/add-output-to-file-option","pushedAt":"2024-01-12T18:58:32.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"Forgind","name":null,"path":"/Forgind","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12969783?s=80&v=4"},"commit":{"message":"Permit specifying output file\n\nFor get* CLI switches","shortMessageHtmlLink":"Permit specifying output file"}},{"before":"c54614c7e8f6d0256ef8ad0000043ba7ac113545","after":"113d2d3618cd8dd82ee00c68a03c0073d0998b60","ref":"refs/heads/targetResults-optimizations","pushedAt":"2024-01-04T17:02:48.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Forgind","name":null,"path":"/Forgind","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12969783?s=80&v=4"},"commit":{"message":"Apply suggestions from code review\n\nCo-authored-by: Jeff Kluge <jeffkl@microsoft.com>","shortMessageHtmlLink":"Apply suggestions from code review"}},{"before":null,"after":"c54614c7e8f6d0256ef8ad0000043ba7ac113545","ref":"refs/heads/targetResults-optimizations","pushedAt":"2024-01-04T01:04:47.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"Forgind","name":null,"path":"/Forgind","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12969783?s=80&v=4"},"commit":{"message":"Optimize no-Returns case","shortMessageHtmlLink":"Optimize no-Returns case"}},{"before":null,"after":"51f3ded12e0ae1606b7eb8be91d3e116386b3c07","ref":"refs/heads/buildincludeoperation-optimizations","pushedAt":"2023-12-28T00:01:19.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"Forgind","name":null,"path":"/Forgind","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12969783?s=80&v=4"},"commit":{"message":"Use default","shortMessageHtmlLink":"Use default"}},{"before":"26049577a8827827139749d72edb6d8c587761f9","after":"400c9e8ffd014381f015cde916dbc3d752dd638c","ref":"refs/heads/log-before-unregistering","pushedAt":"2023-12-21T22:05:19.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Forgind","name":null,"path":"/Forgind","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12969783?s=80&v=4"},"commit":{"message":"Get real exception","shortMessageHtmlLink":"Get real exception"}},{"before":"aec1188ada934314fec88d101b09c00274c85a44","after":"26049577a8827827139749d72edb6d8c587761f9","ref":"refs/heads/log-before-unregistering","pushedAt":"2023-12-21T21:53:36.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Forgind","name":null,"path":"/Forgind","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12969783?s=80&v=4"},"commit":{"message":"We throw anyway; no need to unregister here","shortMessageHtmlLink":"We throw anyway; no need to unregister here"}},{"before":null,"after":"aec1188ada934314fec88d101b09c00274c85a44","ref":"refs/heads/log-before-unregistering","pushedAt":"2023-12-21T21:52:54.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"Forgind","name":null,"path":"/Forgind","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12969783?s=80&v=4"},"commit":{"message":"Do not unregister the handler handling this exception","shortMessageHtmlLink":"Do not unregister the handler handling this exception"}},{"before":"64b38c8ede9428810c8a22f7575fcb5af25b53a5","after":"41611f1129380719a880f52f2273909ab1aa5d81","ref":"refs/heads/invalid-not-internal","pushedAt":"2023-11-18T00:55:18.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Forgind","name":null,"path":"/Forgind","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12969783?s=80&v=4"},"commit":{"message":"Add unit test","shortMessageHtmlLink":"Add unit test"}},{"before":"6f3911ffe0b24bc4ef96d8ede0bf4811f560a075","after":"64b38c8ede9428810c8a22f7575fcb5af25b53a5","ref":"refs/heads/invalid-not-internal","pushedAt":"2023-11-17T20:10:38.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Forgind","name":null,"path":"/Forgind","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12969783?s=80&v=4"},"commit":{"message":"Update src/MSBuild/XMake.cs\n\nCo-authored-by: Rainer Sigwald <raines@microsoft.com>","shortMessageHtmlLink":"Update src/MSBuild/XMake.cs"}},{"before":"30ece66249c93a5fe089a8336e624e0c09831724","after":"6f3911ffe0b24bc4ef96d8ede0bf4811f560a075","ref":"refs/heads/invalid-not-internal","pushedAt":"2023-11-08T22:36:52.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Forgind","name":null,"path":"/Forgind","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12969783?s=80&v=4"},"commit":{"message":"Don't duplicate error","shortMessageHtmlLink":"Don't duplicate error"}},{"before":"3c060b6ead775d8a46b99482fe876e50681c2bc2","after":"30ece66249c93a5fe089a8336e624e0c09831724","ref":"refs/heads/invalid-not-internal","pushedAt":"2023-11-08T18:35:52.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Forgind","name":null,"path":"/Forgind","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12969783?s=80&v=4"},"commit":{"message":"Move catch","shortMessageHtmlLink":"Move catch"}},{"before":"786a703bcaaecd4be2f927a1ee9794076255d952","after":"3c060b6ead775d8a46b99482fe876e50681c2bc2","ref":"refs/heads/invalid-not-internal","pushedAt":"2023-11-06T21:39:46.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Forgind","name":null,"path":"/Forgind","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12969783?s=80&v=4"},"commit":{"message":"Put errors on own line","shortMessageHtmlLink":"Put errors on own line"}},{"before":null,"after":"786a703bcaaecd4be2f927a1ee9794076255d952","ref":"refs/heads/invalid-not-internal","pushedAt":"2023-11-06T21:37:56.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"Forgind","name":null,"path":"/Forgind","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12969783?s=80&v=4"},"commit":{"message":"Catch InvalidProjectFileException","shortMessageHtmlLink":"Catch InvalidProjectFileException"}},{"before":"2115a1bc48690d0f4c274d5b5daf40664015aca8","after":null,"ref":"refs/heads/restore-getproperty","pushedAt":"2023-10-19T22:42:16.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"Forgind","name":null,"path":"/Forgind","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12969783?s=80&v=4"}},{"before":null,"after":"2115a1bc48690d0f4c274d5b5daf40664015aca8","ref":"refs/heads/restore-getproperty","pushedAt":"2023-10-18T20:18:57.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"Forgind","name":null,"path":"/Forgind","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12969783?s=80&v=4"},"commit":{"message":"Add test","shortMessageHtmlLink":"Add test"}},{"before":"ea0db7fab67df57a800e59a56ea024b7963109a1","after":"bc28cf1f9bb631102e85468a18087faefc923b07","ref":"refs/heads/fix-console-mode","pushedAt":"2023-09-07T17:25:55.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Forgind","name":null,"path":"/Forgind","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12969783?s=80&v=4"},"commit":{"message":"PR comments","shortMessageHtmlLink":"PR comments"}},{"before":"4d7fdb3641eb656af1b47871d36b5f8117d302d3","after":"6f528f9872a102db7067ccbb11d6b93288d9aa34","ref":"refs/heads/bring-back-eval-results","pushedAt":"2023-08-29T21:44:31.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"rainersigwald","name":"Rainer Sigwald","path":"/rainersigwald","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3347530?s=80&v=4"},"commit":{"message":"Merge bring-back-eval-results into main (#9138)","shortMessageHtmlLink":"Merge bring-back-eval-results into main (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1855810563\" data-permission-text=\"Title is private\" data-url=\"https://github.com/dotnet/msbuild/issues/9138\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/dotnet/msbuild/pull/9138/hovercard\" href=\"https://github.com/dotnet/msbuild/pull/9138\">dotnet#9138</a>)"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEQvcKXwA","startCursor":null,"endCursor":null}},"title":"Activity · Forgind/msbuild"}