Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify correct settings of PrivateAssets #851

Closed
tom-englert opened this issue Apr 25, 2020 · 0 comments
Closed

Verify correct settings of PrivateAssets #851

tom-englert opened this issue Apr 25, 2020 · 0 comments
Assignees
Labels
Milestone

Comments

@tom-englert
Copy link
Member

After installing a weaver via NuGet, the PrivateAssets="all" is missing in the PackageReference node, which results in the weavers attribute assembly being listed in the copy-local dependencies.

Setting <DevelopmentDependency>true</DevelopmentDependency> in the weavers NuGet package is not an option, since this will create an unusable <IncludeAssets> entry, so after installing a weaver the PrivateAssets="all" must be set manually.

Since this is likely to be forgotten or overlooked, Fody should emit a warning/error when a weaver with the ShouldCleanReference set to true does not have a corresponding PrivateAssets="all" in the project file.

Only usage via PackageReference in the project file will be supported.

(Fixes Fody/PropertyChanged#567)

@tom-englert tom-englert self-assigned this Apr 25, 2020
@tom-englert tom-englert added this to the 6.1.3 milestone May 30, 2020
@tom-englert tom-englert modified the milestones: 6.1.3, 6.2.0 May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant