Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guard class doesn't have a namespace and it causes conflict #822

Closed
giokh opened this issue Mar 19, 2020 · 4 comments
Closed

Guard class doesn't have a namespace and it causes conflict #822

giokh opened this issue Mar 19, 2020 · 4 comments
Milestone

Comments

@giokh
Copy link
Contributor

giokh commented Mar 19, 2020

Hello
Guard class (in FodyHelpers) doesnt have a namespace.
If any project contains a class with this name, there is a conflict on build.
Please add a namespace for the class.

@SimonCropp
Copy link
Member

To be raising issues you should be a patron of Fody. Any issues raised by non Patrons may not be actively triaged, and eventually closed as stale.

@giokh
Copy link
Contributor Author

giokh commented Mar 20, 2020

To be raising issues you should be a patron of Fody. Any issues raised by non Patrons may not be actively triaged, and eventually closed as stale.

Actualy I have already made a pull request about this.
Please take a look.
Writing classes without a namespace is not a good practice.

@SimonCropp
Copy link
Member

yep i will get to deploying that this weekend. although i am surprised a fody weaver would have a type conflict for that name, given weavers dont have a public api

can you point me to the codebase containing the weaver so i can have a look at the scenario

@SimonCropp
Copy link
Member

can you point me to the codebase containing the weaver so i can have a look at the scenario

bump

@SimonCropp SimonCropp added this to the 6.1.2 milestone Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants