Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Obsolete function delegates #804

Closed
SimonCropp opened this issue Feb 2, 2020 · 0 comments
Closed

Obsolete function delegates #804

SimonCropp opened this issue Feb 2, 2020 · 0 comments
Labels
Milestone

Comments

@SimonCropp
Copy link
Member

SimonCropp commented Feb 2, 2020

BaseModuleWeaver has some technical debt. In earlier versions, before the FodyHelpers nuget and the existence of BaseModuleWeaver, weavers could be any type and duck typing was uses to set function delegates. When BaseModuleWeaver was added, there was a period where "any type" approach was supported, so weaver could optionally inherit from BaseModuleWeaver. This meant that the setting function delegates approach was also used for BaseModuleWeaver. Since weavers are now required to inherit from BaseModuleWeaver proper method, and overloads, can be used. As such the following methods have been obsoleted (with warning) and alternatives added.

  • FindType => FindTypeDefinition
  • TryFindType => TryFindTypeDefinition
  • LogDebug => WriteDebug
  • LogInfo => WriteInfo
  • LogMessage => WriteMessage
  • LogWarning => WriteWarning
  • LogWarningPoint => WriteWarning
  • LogError => WriteError
  • LogErrorPoint = >WriteError

Also obsolete TryFindTypeFunc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant