Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetHashCode should match IL generated during release build and avoid intermediate variables #122

Open
ndrwrbgs opened this issue Sep 30, 2019 · 0 comments

Comments

@ndrwrbgs
Copy link
Contributor

I deleted the template, I'm a bad patron :(
Similar discovery route, but different BUG, from #121

Made unit test to try to compare the weave results against what the compiler would do (so instead of having a comment in the readme.md about what it's similar to, we could assert it's the same as that!) -- master...ndrwrbgs:testTheActualIL

However, note the TODOs in the test file

For GetHashCode - our IL seems to get the value and store it in an intermediate, whereas the retail version seems to avoid this intermediate using only the stack

master...ndrwrbgs:testTheActualIL#diff-487b86d49e3d25f0b2efe6336d19cc22R564

Note that unlike #121, I am NOT confident of my interpretation of the IL differences here, I am not an IL ninja like y'all, but I do note some V__0 and V__1 that aren't present in the NormalClassResult's compiled output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant