Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a targets file that removes embedded assemblies from the publish directory #690

Conversation

0xced
Copy link
Contributor

@0xced 0xced commented Apr 6, 2021

If that behaviour is not desirable by consumer of Costura, it can be disabled by setting the following property in the project file:

<CosturaRemoveCopyLocalFilesToPublish>false</CosturaRemoveCopyLocalFilesToPublish>

This was possible thanks to Fody/Fody#981 which has been merged and published in Fody 6.5.0.

Fixes #689

…directory

If that behaviour is not desirable by consumer of Costura, it can be disabled by setting the following property in the project file:
```xml
<CosturaRemoveCopyLocalFilesToPublish>false</CosturaRemoveCopyLocalFilesToPublish>
```

This was possible thanks to Fody/Fody#981 which has been merged and published in Fody 6.5.0.

Fixes Fody#689
@0xced 0xced force-pushed the CosturaRemoveAlreadyEmbeddedFilesFromPublish branch from 1ccb066 to 263436a Compare April 6, 2021 10:00
Copy link
Member

@GeertvanHorrik GeertvanHorrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic PR, thanks for your contribution

@GeertvanHorrik GeertvanHorrik merged commit d7de416 into Fody:develop Apr 7, 2021
@GeertvanHorrik GeertvanHorrik added this to the 5.2.0 milestone Apr 7, 2021
@0xced 0xced deleted the CosturaRemoveAlreadyEmbeddedFilesFromPublish branch April 7, 2021 12:01
@0xced
Copy link
Contributor Author

0xced commented Apr 12, 2021

Thanks for merging, Geert. Do you plan to release version 5.2.0 anytime soon? I can't wait to remove my RemoveAlreadyEmbeddedFilesFromPublish workaround targets from all my projects and above all, not having to think about it for my next projects! 😀

@GeertvanHorrik
Copy link
Member

releasing beta now, if that works for you, I'll release stable

@GeertvanHorrik
Copy link
Member

@0xced
Copy link
Contributor Author

0xced commented Apr 12, 2021

Thanks! I just tested on a few projects and everything works as expected with version 5.2.0-beta0000, i.e. all references are not copied into the publish directory. 😀

@GeertvanHorrik
Copy link
Member

Thanks for the fast feedback, 5.2.0 is being released:

https://www.nuget.org/packages/Costura.Fody/5.2.0

@0xced
Copy link
Contributor Author

0xced commented Apr 12, 2021

Awesome, thanks! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Embedded assemblies should not be published
2 participants