Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add keyName to integrations #330

Merged
merged 2 commits into from Oct 31, 2022
Merged

feat: add keyName to integrations #330

merged 2 commits into from Oct 31, 2022

Conversation

wasabeef
Copy link
Member

@wasabeef wasabeef commented Oct 31, 2022

What does this change?

Fixes #322 #327 馃幆

Change to asset.gen.dart same properties.

When package_parameter_enabled = true

String get path => _assetName;

String get keyName => 'packages/$packageName/\$_assetName';

When package_parameter_enabled = false

String get path => _assetName;

String get keyName => _assetName;

Type of change

Please delete options that are not relevant.

  • New feature (BREAKING CHANGES)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
    • Ensure the tests (melos unit:test-script)
    • Ensure the analyzer and formatter pass (melos run format to automatically apply formatting)
  • Appropriate docs were updated (if necessary)

@wasabeef wasabeef added this to the 5.1.0 milestone Oct 31, 2022
@wasabeef wasabeef merged commit da7bece into main Oct 31, 2022
@wasabeef wasabeef deleted the feat-keyname-integrations branch October 31, 2022 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: The path of assets is not correct
1 participant