Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Wrong output assets path with integrations. #327

Closed
2 tasks done
wasabeef opened this issue Oct 24, 2022 · 2 comments
Closed
2 tasks done

[BUG]: Wrong output assets path with integrations. #327

wasabeef opened this issue Oct 24, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@wasabeef
Copy link
Member

Is there an existing issue for this?

  • I have searched the existing issues

Version

5.0.3

Command type

build_runner (Default)

What happened?

This just broke svg images in my app... path that was previously correctly packages/package_name/images/misc/foo.svg after upgrade became packages/package_name/packages/package_name/images/misc/foo.svg which obviously doesn't work. What am I doing wrong? In any case, 5.0.3 was definitely not a backward-compatible update.

#322 (comment)

Relevant a pubspec.yaml.

No response

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@wasabeef wasabeef added the bug Something isn't working label Oct 24, 2022
@noinskit
Copy link

Friendly ping?

I've got nothing against exposing the full path including the package in generated classes. In fact, AssetGenImage has been doing that for a long time (path vs keyName).

What's making me nervous is changing the semantics of public fields in a minor version update without a warning, and doing this with naming inconsistent between different autogenerated classes (SvgGenImage vs AssetGenImage).

This was referenced Oct 31, 2022
@wasabeef
Copy link
Member Author

wasabeef commented Nov 1, 2022

@noinskit
I just released v5.1.0.

@wasabeef wasabeef closed this as completed Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants