Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #323 TypeError when list json with lottie #324

Merged
merged 2 commits into from Oct 20, 2022

Conversation

wasabeef
Copy link
Member

What does this change?

Fixes #323

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
    • Ensure the tests (melos unit:test-script)
    • Ensure the analyzer and formatter pass (melos run format to automatically apply formatting)
  • Appropriate docs were updated (if necessary)

@wasabeef wasabeef merged commit 9e4f630 into main Oct 20, 2022
@wasabeef wasabeef deleted the fix-gen-failed-only-list-json branch October 20, 2022 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: gen fails when there is only list in a JSON
1 participant