Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LottieGenImage.lottie ignores the controller argument (5.0.1) #308

Closed
noinskit opened this issue Sep 29, 2022 · 2 comments · Fixed by #309
Closed

LottieGenImage.lottie ignores the controller argument (5.0.1) #308

noinskit opened this issue Sep 29, 2022 · 2 comments · Fixed by #309
Assignees
@wasabeef
Milestone
5.0.2

Comments

@noinskit
Copy link

noinskit commented Sep 29, 2022 •
edited

The autogenerated LottieGenImage takes Animation<double>? controller as argument, but it just ignores it instead of passing it to Lottie.asset().
@wasabeef wasabeef added this to the 5.0.2 milestone Sep 29, 2022
@wasabeef wasabeef self-assigned this Sep 29, 2022
@wasabeef
Copy link
Member

Thank you for the report.

@wasabeef wasabeef mentioned this issue Sep 29, 2022
Merged
@wasabeef wasabeef mentioned this issue Oct 12, 2022
Merged
@wasabeef
Copy link
Member

@noinskit
I just released v5.0.2 its fixed the bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wasabeef wasabeef

Labels
None yet
Projects
None yet
Milestone
5.0.2
Development

Successfully merging a pull request may close this issue.

fix: set controller to lottie.asset. FlutterGen/flutter_gen
2 participants
@wasabeef @noinskit