Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate code that supports implicit-dynamic: false (list of all assets) #301

Closed
noinskit opened this issue Sep 28, 2022 · 1 comment · Fixed by #303
Closed

Generate code that supports implicit-dynamic: false (list of all assets) #301

noinskit opened this issue Sep 28, 2022 · 1 comment · Fixed by #303
Assignees
Milestone

Comments

@noinskit
Copy link

The new "list of all assets" feature (values on generated classes) can trigger implicit_dynamic_list_literal warnings when implicit-dynamic: false is configured in the analyzer.

It does not happen if a directory contains all files of the same type, but it does for a directory e.g. mixing svg and png files, making values to be of type dynamic (BTW non-nullable Object would be more precise).

ignore_for_file: implicit_dynamic_list_literal might be enough to work this around.

@wasabeef
Copy link
Member

wasabeef commented Sep 28, 2022

@noinskit Thanks, I'll release that this week.

@wasabeef wasabeef self-assigned this Sep 29, 2022
@wasabeef wasabeef added this to the 5.0.1 milestone Sep 29, 2022
wasabeef added a commit that referenced this issue Sep 29, 2022
* fix: #301 add implicit_dynamic_list_literal to generated files

* test: update actual files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants