Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EventFiringWebDriver is deprecated #1399

Open
abendt opened this issue Dec 8, 2021 · 8 comments
Open

EventFiringWebDriver is deprecated #1399

abendt opened this issue Dec 8, 2021 · 8 comments
Assignees
Milestone

Comments

@abendt
Copy link
Collaborator

abendt commented Dec 8, 2021

EventFiringWebDriver is marked as deprecated in Selenium 4: https://www.selenium.dev/selenium/docs/api/java/org/openqa/selenium/support/events/EventFiringWebDriver.html

@diemol
Copy link

diemol commented Dec 21, 2023

Heads up, the code has been deleted and it won't be in Selenium 4.17

@regulskimichal
Copy link
Contributor

And it's gone

@mkurz
Copy link

mkurz commented Feb 29, 2024

Can't use FluentLenium 6.0.0 with latest Selenium 4.18.1:

[error] Caused by: java.lang.NoClassDefFoundError: org/openqa/selenium/support/events/EventFiringWebDriver
[error]     at io.fluentlenium.core.FluentDriver.<init>(FluentDriver.java:94)
[error]     at io.fluentlenium.adapter.IFluentAdapter.initFluent(IFluentAdapter.java:62)
[error]     at io.fluentlenium.adapter.IFluentAdapter.initFluent(IFluentAdapter.java:70)

Needs to be replaced: https://github.com/search?q=repo%3AFluentLenium%2FFluentLenium%20EventFiringWebDriver&type=code

This might help: https://www.selenium.dev/blog/2023/java-removal-of-deprecated-events-classes/

Thanks!

@mkurz
Copy link

mkurz commented May 3, 2024

@filipcynarski if you have time, can you give an update if or when you could work on that? Would you accept contributions so you can cut a new release soon? This is a blocker for us. Thanks!

@mkurz
Copy link

mkurz commented May 3, 2024

Also pinging @abendt, would appreciate a comment, thanks!

@abendt
Copy link
Collaborator Author

abendt commented May 4, 2024

hi @mkurz

To me, moving away from EventFiringWebDriver does not look like a small change, as there are some differences in how the EventFiringDecorator replacement works. Personally, I don't have the capacity to work on it; I could only offer to do reviews if you want to work on it.

@filipcynarski
Copy link
Member

@mkurz sorry for the late response - I personally don't have the capacity too. It is a bigger refactoring. I can offer code reviews and release management but something more time-consuming is not what I can do at this stage.

@mkurz
Copy link

mkurz commented May 6, 2024

Thanks for the update @abendt and @filipcynarski!

@regulskimichal @diemol you commented here also, do you think you have the capacity to work on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants