-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EventFiringWebDriver is deprecated #1399
Comments
Heads up, the code has been deleted and it won't be in Selenium 4.17 |
And it's gone |
Can't use FluentLenium 6.0.0 with latest Selenium 4.18.1:
Needs to be replaced: https://github.com/search?q=repo%3AFluentLenium%2FFluentLenium%20EventFiringWebDriver&type=code This might help: https://www.selenium.dev/blog/2023/java-removal-of-deprecated-events-classes/ Thanks! |
@filipcynarski if you have time, can you give an update if or when you could work on that? Would you accept contributions so you can cut a new release soon? This is a blocker for us. Thanks! |
Also pinging @abendt, would appreciate a comment, thanks! |
hi @mkurz To me, moving away from EventFiringWebDriver does not look like a small change, as there are some differences in how the EventFiringDecorator replacement works. Personally, I don't have the capacity to work on it; I could only offer to do reviews if you want to work on it. |
@mkurz sorry for the late response - I personally don't have the capacity too. It is a bigger refactoring. I can offer code reviews and release management but something more time-consuming is not what I can do at this stage. |
Thanks for the update @abendt and @filipcynarski! @regulskimichal @diemol you commented here also, do you think you have the capacity to work on this? |
EventFiringWebDriver is marked as deprecated in Selenium 4: https://www.selenium.dev/selenium/docs/api/java/org/openqa/selenium/support/events/EventFiringWebDriver.html
The text was updated successfully, but these errors were encountered: