Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fluent date #103

Merged
merged 5 commits into from
May 3, 2022
Merged

Add fluent date #103

merged 5 commits into from
May 3, 2022

Conversation

mariusz-schimke
Copy link
Contributor

@mariusz-schimke mariusz-schimke commented Apr 19, 2022

I was wondering if you would accept the following changes. My intention is to let specify dates by typing a month name next to an integer year like this: 2022.Apr(19), with a possibility to express time as well: 2022.Apr(19).At(22, 50). I thought I could propose these changes to you as they apparently seem to fit to your library, but I will understand if you don't agree ;). I just thought it would make no sense to create a separate NuGet package for this.

Thanks!

Adds support for dates expressed with month names available on integers
@mariusz-schimke
Copy link
Contributor Author

mariusz-schimke commented Apr 20, 2022

I forgot to mention the intention behind this implementation. It's for those situations where you provide a date statically, and it stays in the code base. W use that for automating database migrations creation using Nuke Build. I thought it would be more readable than new DateTime(2022, 4, 20) or Date.Parse("2022-04-20") or so, but its a matter of individual preferences. It could possibly be used in unit tests as well.

@mariusz-schimke mariusz-schimke marked this pull request as ready for review April 20, 2022 18:49
@SimonCropp SimonCropp added this to the 2.1.0 milestone May 3, 2022
@SimonCropp SimonCropp merged commit 6a9f966 into FluentDateTime:main May 3, 2022
@SimonCropp
Copy link
Member

thanks. will deploy now

@mariusz-schimke
Copy link
Contributor Author

Thanks, I appreciate it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants