Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include VSparkline for use in ui-template #798

Closed
joepavitt opened this issue Apr 25, 2024 · 4 comments · Fixed by #799
Closed

Include VSparkline for use in ui-template #798

joepavitt opened this issue Apr 25, 2024 · 4 comments · Fixed by #799
Assignees
Labels
blocked feature-request New feature or request that needs to be turned into Epic/Story details size:XS - 1 Sizing estimation point

Comments

@joepavitt
Copy link
Collaborator

Description

Vuetify has recently released the "VSparkline" widget into it's component library. This component would be very popular with the Node-RED community, so I looked into including it by default as a standard Vuetify component. It's currently in the Vuetify "labs" which requires us to manually import it.

Unfortunately, it's got a bug that prevents the most common use case we would have, meaning the width of the chart reduces as more data is added. I have reported the details here

Once that is resolved, which should include the VSparkline by default for us in a ui-template node.

Have you provided an initial effort estimate for this issue?

I have provided an initial effort estimate

@joepavitt joepavitt added needs-triage Needs looking at to decide what to do feature-request New feature or request that needs to be turned into Epic/Story details size:XS - 1 Sizing estimation point blocked and removed needs-triage Needs looking at to decide what to do labels Apr 25, 2024
@joepavitt joepavitt changed the title Include VSparkline for us in ui-template Include VSparkline for use in ui-template Apr 25, 2024
@joepavitt
Copy link
Collaborator Author

For now, as a first iteration, we can include:

.nrdb-ui-sparkline path {
  stroke-dasharray: 0 !important;
}

in the ui-template, and attach the appropriate class to the v-sparkline to circumvent the blocking issue.

@joepavitt
Copy link
Collaborator Author

Screenshot 2024-04-25 at 11 39 52

@Steve-Mcl
Copy link
Contributor

For now, as a first iteration, we can include:

.nrdb-ui-sparkline path {
  stroke-dasharray: 0 !important;
}

in the ui-template, and attach the appropriate class to the v-sparkline to circumvent the blocking issue.

FWIW, your comment on the vuetify issue states:

It does seem to be linked to the dash offset value on the path:

Removing the dashoffset in the CSS dev tools fixes the issue:

Emphasis on offset - should be dasharray (as in stroke-dasharray)

@joepavitt
Copy link
Collaborator Author

Thanks @Steve-Mcl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked feature-request New feature or request that needs to be turned into Epic/Story details size:XS - 1 Sizing estimation point
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants