Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Movie via Web UI doesn't get imdb / tmdb ID #101

Open
pree opened this issue Apr 5, 2020 · 1 comment
Open

Adding Movie via Web UI doesn't get imdb / tmdb ID #101

pree opened this issue Apr 5, 2020 · 1 comment

Comments

@pree
Copy link

pree commented Apr 5, 2020

When I try adding a movie via the web ui it doesn't lookup imdb/tmdb, adding the same movie via CLI works fine.

@evoblicec
Copy link
Contributor

After code review WebUI is calling api/movie_list using movie_name parameter, thus putting all the input text box inside movie_name.

On the other hand CLI adding is doing some logic before adding the entry:

def movie_list_add(options):

        title, year = split_title_year(options.movie_title)
        console('Trying to lookup movie title: `{}`'.format(title))
        movie_lookup = lookup_movie(title=title, session=session, identifiers=options.identifiers)

and in addition CLI add is support identifier used to specify for example imdb_id or tmdb_id

IMHO the simplest way to support that would be to propose in the WebUi multiple input text boxes:

  • Movie Name (Mandatory)
  • Year (optionnal)
  • IMDB_ID (optionnal)
  • TMDB_ID (optionnal)

For now i'm relying only on CLI pour adding new entries

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants