Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Node-Tree-Kill does not work on macOS #220

Closed
pyrox0 opened this issue Jun 4, 2021 · 1 comment
Closed

[BUG] Node-Tree-Kill does not work on macOS #220

pyrox0 opened this issue Jun 4, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@pyrox0
Copy link

pyrox0 commented Jun 4, 2021

Describe the bug
As described in pkrumins/node-tree-kill#28, tree-kill does not work on macOS.

To Reproduce
Steps to reproduce the behavior:
This is currently hard to reproduce, as it only happens on macOS, and >99% of flashpoint activity is on Windows. However, in my work porting flashpoint to mac, this bug comes up.

Expected behavior
I expected flashpoint to kill the process.

Screenshots
See the logs here: https://logs.unstable.life/log?id=4BVSXUSS

Desktop (please complete the following information):

  • OS: macOS
  • Flashpoint Version 10, built from branch release/10.0.0 latest commit
  • Log text: See screenshots.

Additional contextI and another developer, ColdIce#0001 on discord, suggest using tmbr as a replacement, as it is more recently updated and seems to have a simpler syntax than tree-kill.

@pyrox0 pyrox0 added the bug Something isn't working label Jun 4, 2021
@n0samu n0samu added this to To Do in Release 11.0 Mar 23, 2022
@LindirQuenya
Copy link
Member

It seems that I can't use GitHub's built-in "assign" feature, so I'll use a comment as a substitute.

This is what I'm currently working on.

@LindirQuenya LindirQuenya moved this from To Do to In Progress in Release 11.0 Apr 10, 2022
@pyrox0 pyrox0 closed this as completed May 9, 2022
@n0samu n0samu moved this from In Progress to Done in Release 11.0 May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Development

No branches or pull requests

2 participants