Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comply to CLS #63

Open
thomas-pemsel opened this issue Apr 1, 2021 · 2 comments
Open

Comply to CLS #63

thomas-pemsel opened this issue Apr 1, 2021 · 2 comments

Comments

@thomas-pemsel
Copy link
Collaborator

This cast from uint to int is necessary because of the Take operation we use inside the shuffler. This could be a - albeit very theoretical - future problem when we introduce custom minefields since one could define a minecount that's greater than an int.
For now maybe we should throw an ArgumentException in the constructor of the Minefield in case someone tries to generate it with a minecount greater than int.MaxValue?

Originally posted by @dev-in-disguise in #56 (comment)

@thomas-pemsel
Copy link
Collaborator Author

thomas-pemsel commented Apr 1, 2021

Add CLSCompliantAttribute and change e.g. uint to int with negative value validation.
Use ArgumentOutOfRangeException

@dev-in-disguise
Copy link
Collaborator

Hopefully dotnet/msbuild#6285 is implemented by then ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants