From d73893aacf4ebb854cb133c2feea56b748dc10cc Mon Sep 17 00:00:00 2001 From: Mark Rotteveel Date: Sun, 2 Aug 2020 17:36:01 +0200 Subject: [PATCH] Move static config in modules to constructor See also https://github.com/testcontainers/testcontainers-java/pull/2473 --- CHANGES.md | 4 +++- .../org/firebirdsql/testcontainers/FirebirdContainer.java | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/CHANGES.md b/CHANGES.md index 32aac0a..9b9281d 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -4,7 +4,9 @@ Version History 1.0.4 ----- -- Update org.testcontainers:jdbc to 1.14.3 +- Update org.testcontainers:jdbc to 1.14.3 +- Move static config in modules to constructor (see also https://github.com/testcontainers/testcontainers-java/pull/2473) + 1.0.3 ----- diff --git a/src/main/java/org/firebirdsql/testcontainers/FirebirdContainer.java b/src/main/java/org/firebirdsql/testcontainers/FirebirdContainer.java index e324992..5a85935 100644 --- a/src/main/java/org/firebirdsql/testcontainers/FirebirdContainer.java +++ b/src/main/java/org/firebirdsql/testcontainers/FirebirdContainer.java @@ -34,11 +34,11 @@ public FirebirdContainer() { public FirebirdContainer(String dockerImageName) { super(dockerImageName); + addExposedPort(FIREBIRD_PORT); } @Override protected void configure() { - addExposedPort(FIREBIRD_PORT); addEnv("TZ", timeZone); addEnv("FIREBIRD_DATABASE", databaseName);