Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Service account creation doc incomplete #240

Closed
kribor opened this issue Oct 6, 2022 · 6 comments
Closed

[BUG] Service account creation doc incomplete #240

kribor opened this issue Oct 6, 2022 · 6 comments
Labels
bug Something isn't working

Comments

@kribor
Copy link

kribor commented Oct 6, 2022

Action config

- uses: FirebaseExtended/action-hosting-deploy@v0
  with:
    repoToken: "${{ secrets.GITHUB_TOKEN }}"
    firebaseServiceAccount: "${{ secrets.FIREBASE_SERVICE_ACCOUNT }}"
    expires: 30d
    projectId: my-awesome-project

Error message

Relevant part of deployment error:
Error: HTTP Error: 403, Permission 'cloudfunctions.functions.list' denied on 'projects/natural-cycles/locations/-/functions'

Expected behavior

Successful deployment

Actual behavior

Failed deployment

Proposed solution

Add another role to documentation: https://github.com/FirebaseExtended/action-hosting-deploy/blob/main/docs/service-account.md that includes cloudfunctions.functions.list. Adding Firebase Develop Admin works but may not be "minimal required"

@kribor kribor added the bug Something isn't working label Oct 6, 2022
@aaronadamsCA
Copy link

Our long-standing uses of this action suddenly started failing in the last 2 days with this same error message, so I get the feeling this is the result of a change, inadvertent or not.

We don't have any functions, so I'm not sure why our deploy process would need permission to list functions.

@aaronadamsCA
Copy link

aaronadamsCA commented Oct 6, 2022

Yep, it's a bug introduced in an upstream release 6 hours ago: firebase/firebase-tools#5071

@ihor-panasiuk95
Copy link

Same for us :(
We also have troubles during deployment caused exactly the same error.

@AurelienLoyer
Copy link

Same issue on my side 😕

Screen Shot 2022-10-06 at 5 50 49 PM

AurelienLoyer added a commit to AurelienLoyer/action-hosting-deploy that referenced this issue Oct 6, 2022
AurelienLoyer added a commit to AurelienLoyer/action-hosting-deploy that referenced this issue Oct 6, 2022
@AurelienLoyer
Copy link

Looking comments on other issues ( #203 ) i created my own action, forking this one, and pining the firebase-tools version to previous one ( 11.13.0 )

You can find my solution here AurelienLoyer@fbc5bbe

And i replace this in my projet
image

@aaronadamsCA
Copy link

This has been fixed upstream. I believe this issue can be closed now.

@kribor kribor closed this as completed Oct 7, 2022
@FirebaseExtended FirebaseExtended locked and limited conversation to collaborators Nov 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants