Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate entire query param contents for unexpected characters #570

Open
notlee opened this issue Feb 11, 2022 · 0 comments
Open

Validate entire query param contents for unexpected characters #570

notlee opened this issue Feb 11, 2022 · 0 comments
Assignees
@notlee @akomiqaia
Labels
service Relates to an Origami service
Projects
Origami ✨

Comments

@notlee
Copy link
Contributor

notlee commented Feb 11, 2022 •
edited

Currently we split the component query parameter into name/version before validating.
This allowed an invalid component name to be passed through if it contained an
@ symbol e.g. @financial-times/o-table@[naughty]@^0.0.1

This PR ignores anything after the first @. It would be better/safer
to validate the whole parameter content first before processing.
#569
@origamiserviceuser origamiserviceuser added this to Backlog in Origami ✨ Feb 11, 2022
@github-actions github-actions bot added the service Relates to an Origami service label Feb 11, 2022
@notlee notlee added the next planning Used to mark an issue to discuss in Origami's next six-week planning session label Feb 11, 2022
@KamranMuniree KamranMuniree moved this from Backlog to To Do in Origami ✨ Jul 28, 2022
@KamranMuniree KamranMuniree removed the next planning Used to mark an issue to discuss in Origami's next six-week planning session label Jul 28, 2022
@KamranMuniree KamranMuniree added the next planning Used to mark an issue to discuss in Origami's next six-week planning session label Aug 30, 2022
@KamranMuniree KamranMuniree moved this from To Do to Backlog in Origami ✨ Aug 30, 2022
@notlee notlee removed the next planning Used to mark an issue to discuss in Origami's next six-week planning session label Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@notlee notlee

@akomiqaia akomiqaia

Labels
service Relates to an Origami service
Projects
Origami ✨
  
Backlog
Milestone
No milestone
Development

No branches or pull requests
3 participants
@notlee @KamranMuniree @akomiqaia