Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve loading times of demos #554

Open
wheresrhys opened this issue Oct 27, 2021 · 4 comments
Open

Improve loading times of demos #554

wheresrhys opened this issue Oct 27, 2021 · 4 comments
Labels
service Relates to an Origami service
Projects

Comments

@wheresrhys
Copy link

It just struck me that the origami registry demos are possibly the slowest loading things I interact with on the internet on a regular basis and does break up the flow (just now I waited so long I forgot what I'd come to the page for).

I don't think the basic architecture of how these are delivered has changed since the very early days of origami - perhaps its something that can be improved upon?

@JakeChampion
Copy link
Contributor

@wheresrhys We recently overhauled how the demos are built and served and they should definitely be faster than previous implementations, but likely could be improved some more.

We are actually replacing the demos on the registry with an Origami StoryBook implementation, I don't think we will work on improving the registry demos anymore and will concentrate efforts on moving to StoryBook

@wheresrhys
Copy link
Author

FYI, it was o-message (internal brand) that was particularly slow today - maybe there's some edge case in there which makes it particularly slow.

Looking forward to storybook though

@chee
Copy link
Member

chee commented Oct 27, 2021

it's true, the registry is currently really slow to load demos sometimes.

@chee chee transferred this issue from Financial-Times/origami Oct 27, 2021
@github-actions github-actions bot added the service Relates to an Origami service label Oct 27, 2021
@notlee
Copy link
Contributor

notlee commented Oct 28, 2021

Definitely worse since the bower to npm migration. @JakeChampion pointed out before that js/css is inlined now which would slow down the initial response and could hurt perceived performance. Not so bad after the first request though thanks to cache. Part of me wonders if it's worth fixing or ploughing ahead with a story book shaped replacement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service Relates to an Origami service
Projects
Origami ✨
  
Backlog
Development

No branches or pull requests

4 participants