Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve conflict messages #539

Open
notlee opened this issue Jul 23, 2021 · 0 comments
Open

Improve conflict messages #539

notlee opened this issue Jul 23, 2021 · 0 comments
Labels
feature New feature request service Relates to an Origami service
Projects

Comments

@notlee
Copy link
Contributor

notlee commented Jul 23, 2021

When two versions of a component conflict in a bundle request the error message is not very helpful.

https://www.ft.com/__origami/service/build/v3/bundles/css?components=o-layout@%5E5.0.1,o-fonts@%5E5.0.1,o-syntax-highlight@%5E4.0.0,o-table@%5E9.0.0,o-forms@%5E9.0.0,o-buttons@%5E7.0.0,o-header-services@%5E5.0.0,o-footer-services@%5E4.0.1,o-autoinit@%5E3.0.0&brand=internal&system_code=origami

Let's improve it! At the very least we can note that there is a version conflict in more friendly language.

Origami Build Service returned an error: "Command failed: /app/node_modules/.bin/npm install --production --ignore-scripts --no-package-lock --no-audit --prefer-offline --progress=false --fund=false --package-lock=false --strict-peer-deps --update-notifier=false --bin-links=false --registry=https://registry.npmjs.com\nnpm ERR! code ERESOLVE\nnpm ERR! ERESOLVE unable to resolve dependency tree\nnpm ERR! \nnpm ERR! While resolving: undefined@undefined\nnpm ERR! Found: @financial-times/o-fonts@undefined\nnpm ERR! node_modules/@financial-times/o-fonts\nnpm ERR!   peer @financial-times/o-fonts@\"^5.0.1\" from the root project\nnpm ERR! \nnpm ERR! Could not resolve dependency:\nnpm ERR! peer @financial-times/o-fonts@\"^5.0.0\" from @financial-times/o-layout@5.0.1\nnpm ERR! node_modules/@financial-times/o-layout\nnpm ERR!   peer @financial-times/o-layout@\"^5.0.1\" from the root project\nnpm ERR! \nnpm ERR! Fix the upstream dependency conflict, or retry\nnpm ERR! this command with --no-strict-peer-deps, --force, or --legacy-peer-deps\nnpm ERR! to accept an incorrect (and potentially broken) dependency resolution.\nnpm ERR! \nnpm ERR! See /app/.npm/eresolve-report.txt for a full report.\n\nnpm ERR! A complete log of this run can be found in:\nnpm ERR!     /app/.npm/_logs/2021-07-23T15_25_10_922Z-debug.log\n\n"```
@notlee notlee added the feature New feature request label Jul 23, 2021
@github-actions github-actions bot added the service Relates to an Origami service label Jul 23, 2021
@origamiserviceuser origamiserviceuser added this to incoming in Origami ✨ Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature request service Relates to an Origami service
Projects
Origami ✨
  
Backlog
Development

No branches or pull requests

2 participants
@notlee and others