Fix #142 (multiple text events for long segments if requested) #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @johannesherr! Looks good, happy to merge this. Just one last thing: before merging the contribution, I need CLA from here: https://github.com/FasterXML/jackson/ (it's not Jackson-specific, just stored there for convenience) and once I get it (and if you have sent it before let me know, I sometimes forget), I will merge this PR. The usual way to send CLA is to print it, fill relevant parts (name, github user id), sign, scan/photo, email to Thank you again for this contribution: looking forward to merging it! |
|
CLA received, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #142, if coalescing was explicitly set to false by the user, text segments may be returned in multiple text events.