Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues outlined by "lgtm.com"'s static analysis #121

Closed
cowtowncoder opened this issue Jan 5, 2021 · 1 comment
Closed

Fix issues outlined by "lgtm.com"'s static analysis #121

cowtowncoder opened this issue Jan 5, 2021 · 1 comment
Milestone
6.3.0

Comments

@cowtowncoder
Copy link
Member

Looks like there are a few minor but legit issues with Woodstox code, as per:

https://lgtm.com/projects/g/FasterXML/woodstox/

and it'd make sense to go through the list. Creating this issue as a placeholder; may create individual issues if actual severe reproducible problems are found; smaller code hygiene changes can be tracked under this one.
cowtowncoder added a commit that referenced this issue Jan 5, 2021
@cowtowncoder
First minor fix wrt #121; only affects case of (not) detecting invali…
b8eba25 
…d ctrl chars in CDATA

(for one specific read method)
cowtowncoder added a commit that referenced this issue Jan 5, 2021
@cowtowncoder
Remove unnecessary checks wrt #121
bfd149a
cowtowncoder added a commit that referenced this issue Jan 5, 2021
@cowtowncoder
Change never-reachable code from assignmen to return (one more fix for …
0f57cd2 
…#121)
cowtowncoder added a commit that referenced this issue Jan 6, 2021
@cowtowncoder
Some more #121 fixes
90b048a
@cowtowncoder cowtowncoder reopened this Nov 20, 2021
@cowtowncoder
Copy link
Member Author

cowtowncoder commented Nov 20, 2021 •
edited

Actually let's reopen until we are fully done: today reports 15 alerts but with some fixes going in should get down to 12 or so in a day or two.

cowtowncoder added a commit that referenced this issue Nov 20, 2021
@cowtowncoder
And one more LGTM.com warning fix (wrt #121)
72410f4
@cowtowncoder cowtowncoder added this to the 6.3.0 milestone Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.3.0
Development

No branches or pull requests
1 participant
@cowtowncoder