Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing synchronization on ResolvedObjectType#getConstructors #43

Closed
pkwarren opened this issue Apr 23, 2018 · 3 comments
Closed

Missing synchronization on ResolvedObjectType#getConstructors #43

pkwarren opened this issue Apr 23, 2018 · 3 comments
Milestone

Comments

@pkwarren
Copy link

It appears from looking at the code that the ResolvedType#getConstructors method is missing a synchronized keyword. The other methods that behave similarly in the class (getMemberFields, getStaticFields, getMemberMethods) have the keyword specified.

public List<RawConstructor> getConstructors()

@cowtowncoder
Copy link
Member

Thank you for reporting this. I'll have to check to see if there is logic to this, but I assume you are right.

@cowtowncoder cowtowncoder added this to the 1.4.1 milestone Apr 24, 2018
@cowtowncoder cowtowncoder changed the title Missing synchronization on ResolvedObjectType#getConstructors? Missing synchronization on ResolvedObjectType#getConstructors Apr 24, 2018
@cowtowncoder
Copy link
Member

Added synchronized, will be in 1.4.1.

@pkwarren
Copy link
Author

Thanks for the quick turnaround @cowtowncoder!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants