-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
guava and/or hppc test failures if you use guava 33 #148
Comments
Yeah I noticed there was an odd new failure -- not sure it's even related to Guava 33. EDIT: fails 2.18 even without Guava upgrade. No idea why, very odd. |
@pjfanning I figured out the root cause for regression; databind issue FasterXML/jackson-databind#4443. I could not quite figured out how to make that work so reverted it from 2.18 (since it is not 100% necessary change and can be done at a later point if and when finding out how to make it work). I also filed #149 to test against multiple Guava versions, so that even when we upgrade "suggested" version -- one for which module declares dependency, module works on wider range of versions. With that we can increase the baseline, but I think there are some risk (... of getting lots of complaints for "breaking our Guava use" from users that rely on default Guava module brings in if there are no overrides) with going to the latest. Looking at: https://mvnrepository.com/artifact/com.google.guava/guava it looks like 32.0.1-jre is the oldest one with no CVEs, so maybe go with that as baseline? Although I guess that as long as:
I am not as much against bigger leap. |
Ok, I noticed that Basically:
so those are probably the limits to verify. I don't think we really have to support versions before, say, 25.1, but until there's a reason to break compatibility might as well not do that. |
see #147
The text was updated successfully, but these errors were encountered: