Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disabling CsvParser.Feature.FAIL_ON_MISSING_HEADER_COLUMNS has no effect #352

Closed
malteo opened this issue Nov 8, 2022 · 3 comments · Fixed by #353
Closed

Disabling CsvParser.Feature.FAIL_ON_MISSING_HEADER_COLUMNS has no effect #352

malteo opened this issue Nov 8, 2022 · 3 comments · Fixed by #353
Labels
csv
Milestone
2.14.1

Comments

@malteo
Copy link
Contributor

malteo commented Nov 8, 2022

Following a dependency upgrade to version 2.14.0 I get failing tests:

Missing 1 header column: ["specs"]

I found 88a278f from the changelog, but toggling the feature doesn't disable the check (it's quite obvious from the code).
@cowtowncoder
Copy link
Member

Too bad this was not caught during the lengthy Release Candidate period for 2.14.

Would it be possible to contribute a simple test to show the issue since we don't have one that works to catch this problem?

@malteo malteo mentioned this issue Nov 9, 2022
Merged
@malteo
Copy link
Contributor Author

malteo commented Nov 9, 2022

I opened a PR

@cowtowncoder
Copy link
Member

Much appreciated! Added a note on CLA, looking forward to merging the fix!

@cowtowncoder cowtowncoder modified the milestones: 2.10, 2.14.1 Nov 17, 2022
@cowtowncoder cowtowncoder changed the title Disabling FAIL_ON_MISSING_HEADER_COLUMNS has no effect Disabling CsvParser.Feature.FAIL_ON_MISSING_HEADER_COLUMNS has no effect Nov 17, 2022
cowtowncoder added a commit that referenced this issue Nov 17, 2022
@cowtowncoder
Update release notes wrt #352 (follow-up to #285)
cd59497
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
csv
Projects
None yet
Milestone
2.14.1
2 participants
@cowtowncoder @malteo