Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cbor] Write large numbers in uint32 form where possible #200

Closed
wants to merge 1 commit into from

Conversation

yawkat
Copy link
Member

@yawkat yawkat commented Mar 28, 2020

When minimal ints are enabled, the generator will now encode numbers that exceed java int range but still can be encoded as 5 bytes in cbor as such.

When minimal ints are enabled, the generator will now encode numbers that exceed java int range but still can be encoded as 5 bytes in cbor as such.
@cowtowncoder
Copy link
Member

@yawkat I am not 100% sure I understand the issue being fixed here -- would it be possible to create issue to explain the problem (and to include in release notes)?

@yawkat
Copy link
Member Author

yawkat commented Mar 29, 2020

I've opened #201. That issue also includes some other ideas on efficient integer representation.

cowtowncoder added a commit that referenced this pull request Apr 8, 2020
@cowtowncoder
Copy link
Member

I ended up merging the solution manually; same checks, test (but added a few other tests for complteness); closing this. Thank you for submitting it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants